Changeset c8cb0d for src/Box.cpp

Timestamp:

Dec 26, 2025, 9:40:14 PM (6 weeks ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.1, stable

Children:

033646

Parents:

f2d5ce

git-author:

Frederik Heber <frederik.heber@…> (12/10/25 16:15:28)

git-committer:

Frederik Heber <frederik.heber@…> (12/26/25 21:40:14)

Message:

Streamlines channel creation in Observables.

• CodePatterns is now version 1.3.4.
• we no longer need to add the channels manually in the cstor of a class that derives from Observable. Instead, we just need to pass the maximum number of channels (as they are typically enumerated anyway) and they are generated and added.
• added mutex protection when inserting.
• adjusted class Relay to forward similar convenience cstors.
• adjusted all call sites in molecuilder.

File:

• src/Box.cpp (modified) (5 diffs)

src/Box.cpp

@@ -57 +57 @@
 
 Box::Box() :
-    Observable("Box"),
+    Observable("Box", NotificationType_MAX),
     M(new RealSpaceMatrix()),
     Minv(new RealSpaceMatrix())
@@ -65 +65 @@
   index.reserve(NDIM);
 
-  // observable stuff
-  Channels *OurChannel = new Channels;
-  Observable::insertNotificationChannel( std::make_pair(static_cast<Observable *>(this), OurChannel) );
-  // add instance for each notification type
-  for (size_t type = 0; type < NotificationType_MAX; ++type)
-    OurChannel->addChannel(type);
-
   M->setIdentity();
   Minv->setIdentity();
@@ -77 +70 @@
 
 Box::Box(const Box& src) :
-    Observable("Box"),
+    Observable("Box", NotificationType_MAX),
     conditions(src.conditions),
     M(new RealSpaceMatrix(*src.M)),
@@ -85 +78 @@
   coords.reserve(NDIM);
   index.reserve(NDIM);
-
-  // observable stuff
-  Channels *OurChannel = new Channels;
-  Observable::insertNotificationChannel( std::make_pair(static_cast<Observable *>(this), OurChannel) );
-  // add instance for each notification type
-  for (size_t type = 0; type < NotificationType_MAX; ++type)
-    OurChannel->addChannel(type);
 }
 
 Box::Box(RealSpaceMatrix _M) :
-    Observable("Box"),
+    Observable("Box", NotificationType_MAX),
     M(new RealSpaceMatrix(_M)),
     Minv(new RealSpaceMatrix())
@@ -102 +88 @@
   coords.reserve(NDIM);
   index.reserve(NDIM);
-
-  // observable stuff
-  Channels *OurChannel = new Channels;
-  Observable::insertNotificationChannel( std::make_pair(static_cast<Observable *>(this), OurChannel) );
-  // add instance for each notification type
-  for (size_t type = 0; type < NotificationType_MAX; ++type)
-    OurChannel->addChannel(type);
 
   ASSERT(M->determinant()!=0,"Matrix in Box construction was not invertible");