Changeset 76a109 for src/Actions/ActionQueue.cpp

Timestamp:

Feb 4, 2015, 9:56:43 PM (10 years ago)

Author:

Frederik Heber <heber@…>

Children:

3e6b93

Parents:

2e7afe

git-author:

Frederik Heber <heber@…> (09/23/14 16:14:18)

git-committer:

Frederik Heber <heber@…> (02/04/15 21:56:43)

Message:

FIX: Setting ActionQueue::_lastchangedaction without heeding whether Action failed is bad.

• causes segfault when notification informs about change and _lastchangeaction is still NULL (as the very first Action failed).
• we now only notify when action succeeded.

File:

• src/Actions/ActionQueue.cpp (modified) (1 diff)

src/Actions/ActionQueue.cpp

@@ -200 +200 @@
         mtx_queue.unlock();
       }
+      if (lastActionOk) {
+        OBSERVE;
+        NOTIFY(ActionQueued);
+        _lastchangedaction = actionqueue[CurrentAction];
+      }
       // access actionqueue, hence using mutex
       mtx_queue.lock();