Changeset 3e6b93 for src/Parameters/Value_impl.hpp

Timestamp:

Feb 4, 2015, 9:56:43 PM (11 years ago)

Author:

Frederik Heber <heber@…>

Parents:

76a109

git-author:

Frederik Heber <heber@…> (09/23/14 16:34:50)

git-committer:

Frederik Heber <heber@…> (02/04/15 21:56:43)

Message:

Changed checking of Parameter::isValid() on set(), not on get().

• this would fix problems with ActionQueue::OutputAs...() commands that need to get() parameter values after usage by the Action. If files were forced to be non-present before, then written by the Action, the Validator will then fail.

File:

• src/Parameters/Value_impl.hpp (modified) (2 diffs)

src/Parameters/Value_impl.hpp

@@ -119 +119 @@
 inline const T & Value<T>::get() const throw(ParameterValueException)
 {
-  if (!isValid(value)) throw ParameterValueException();
+  // Actions' parameters may later become invalid because a file has been
+  // written that was supposed to not exist (!FilePresentValidator())
+  //  if (!isValid(value)) throw ParameterValueException();
   if (!ValueSet) throw ParameterValueException();
   return value;
@@ -131 +133 @@
 inline void Value<T>::set(const T & _value) throw(ParameterException)
 {
-  // any value may be set, this allows Actions to have invalid parameters
-  // (e.g. because the given atom id does not yet exist) that are checked
-  // on performCall()
-//  if (!isValid(_value)) throw ParameterValueException();
+  if (!isValid(_value)) throw ParameterValueException();
   if (!ValueSet)
     ValueSet = true;