Changeset 29812d for src/molecules.cpp


Ignore:
Timestamp:
Sep 21, 2009, 11:48:42 AM (16 years ago)
Author:
Saskia Metzler <metzler@…>
Branches:
Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable
Children:
b66c22, c30180
Parents:
89c8b2
Message:

Ticket 11: use templates and/or traits to fix Malloc/ReAlloc-Free warnings in a clean manner

File:
1 edited

Legend:

Unmodified
Added
Removed
  • src/molecules.cpp

    r89c8b2 r29812d  
    66
    77#include "config.hpp"
     8#include "memoryallocator.hpp"
    89#include "molecules.hpp"
    910
     
    5556  if (ListOfBondsPerAtom != NULL)
    5657    for(int i=AtomCount;i--;)
    57       Free((void **)&ListOfBondsPerAtom[i], "molecule::~molecule: ListOfBondsPerAtom[i]");
    58   Free((void **)&ListOfBondsPerAtom, "molecule::~molecule: ListOfBondsPerAtom");
    59   Free((void **)&NumberOfBondsPerAtom, "molecule::~molecule: NumberOfBondsPerAtom");
     58      Free(&ListOfBondsPerAtom[i]);
     59  Free(&ListOfBondsPerAtom);
     60  Free(&NumberOfBondsPerAtom);
    6061  if (TesselStruct != NULL)
    6162    delete(TesselStruct);
     
    163164        NoNonHydrogen++;
    164165      if (pointer->Name == NULL) {
    165         Free((void **)&pointer->Name, "molecule::AddAtom: *pointer->Name");
    166         pointer->Name = (char *) Malloc(sizeof(char)*6, "molecule::AddAtom: *pointer->Name");
     166        Free(&pointer->Name);
     167        pointer->Name = Malloc<char>(6, "molecule::AddAtom: *pointer->Name");
    167168        sprintf(pointer->Name, "%2s%02d", pointer->type->symbol, pointer->nr+1);
    168169      }
     
    182183  if (pointer != NULL) {
    183184    atom *walker = new atom(pointer);
    184     walker->Name = (char *) Malloc(sizeof(char)*strlen(pointer->Name)+1, "atom::atom: *Name");
     185    walker->Name = Malloc<char>(strlen(pointer->Name) + 1, "atom::atom: *Name");
    185186    strcpy (walker->Name, pointer->Name);
    186187    walker->nr = last_atom++;  // increase number within molecule
     
    267268    Orthovector1.MatrixMultiplication(matrix);
    268269    InBondvector.SubtractVector(&Orthovector1); // subtract just the additional translation
    269     Free((void **)&matrix, "molecule::AddHydrogenReplacementAtom: *matrix");
     270    Free(&matrix);
    270271    bondlength = InBondvector.Norm();
    271272//    *out << Verbose(4) << "Corrected InBondvector is now: ";
     
    10801081    }
    10811082  } while (!flag);
    1082   Free((void **)&matrix, "molecule::DetermineCenter: *matrix");
     1083  Free(&matrix);
    10831084  Center.Scale(1./(double)AtomCount);
    10841085};
     
    13391340{
    13401341  stringstream zeile1, zeile2;
    1341   int *DoubleList = (int *) Malloc(Nr*sizeof(int), "PrintPermutationMap: *DoubleList");
     1342  int *DoubleList = Malloc<int>(Nr, "PrintPermutationMap: *DoubleList");
    13421343  int doubles = 0;
    13431344  for (int i=0;i<Nr;i++)
     
    13541355    doubles++;
    13551356 // *out << "Found " << doubles << " Doubles." << endl;
    1356   Free((void **)&DoubleList, "PrintPermutationMap: *DoubleList");
     1357  Free(&DoubleList);
    13571358//  *out << zeile1.str() << endl << zeile2.str() << endl;
    13581359};
     
    13881389{
    13891390  double Potential, OldPotential, OlderPotential;
    1390   PermutationMap = (atom **) Malloc(AtomCount*sizeof(atom *), "molecule::MinimiseConstrainedPotential: **PermutationMap");
    1391   DistanceMap **DistanceList = (DistanceMap **) Malloc(AtomCount*sizeof(DistanceMap *), "molecule::MinimiseConstrainedPotential: **DistanceList");
    1392   DistanceMap::iterator *DistanceIterators = (DistanceMap::iterator *) Malloc(AtomCount*sizeof(DistanceMap::iterator), "molecule::MinimiseConstrainedPotential: *DistanceIterators");
    1393   int *DoubleList = (int *) Malloc(AtomCount*sizeof(int), "molecule::MinimiseConstrainedPotential: *DoubleList");
    1394   DistanceMap::iterator *StepList = (DistanceMap::iterator *) Malloc(AtomCount*sizeof(DistanceMap::iterator), "molecule::MinimiseConstrainedPotential: *StepList");
     1391  PermutationMap = Malloc<atom*>(AtomCount, "molecule::MinimiseConstrainedPotential: **PermutationMap");
     1392  DistanceMap **DistanceList = Malloc<DistanceMap*>(AtomCount, "molecule::MinimiseConstrainedPotential: **DistanceList");
     1393  DistanceMap::iterator *DistanceIterators = Malloc<DistanceMap::iterator>(AtomCount, "molecule::MinimiseConstrainedPotential: *DistanceIterators");
     1394  int *DoubleList = Malloc<int>(AtomCount, "molecule::MinimiseConstrainedPotential: *DoubleList");
     1395  DistanceMap::iterator *StepList = Malloc<DistanceMap::iterator>(AtomCount, "molecule::MinimiseConstrainedPotential: *StepList");
    13951396  double constants[3];
    13961397  int round;
     
    14681469    }
    14691470  *out << Verbose(1) << "done." << endl;
    1470   Free((void **)&DoubleList, "molecule::MinimiseConstrainedPotential: *DoubleList");
     1471  Free(&DoubleList);
    14711472  // argument minimise the constrained potential in this injective PermutationMap
    14721473  *out << Verbose(1) << "Argument minimising the PermutationMap, at current potential " << OldPotential << " ... " << endl;
     
    15491550  for (int i=AtomCount; i--;)
    15501551    DistanceList[i]->clear();
    1551   Free((void **)&DistanceList, "molecule::MinimiseConstrainedPotential: **DistanceList");
    1552   Free((void **)&DistanceIterators, "molecule::MinimiseConstrainedPotential: *DistanceIterators");
     1552  Free(&DistanceList);
     1553  Free(&DistanceIterators);
    15531554  return ConstrainedPotential(out, PermutationMap, startstep, endstep, constants, IsAngstroem);
    15541555};
     
    16471648 
    16481649  // store the list to single step files
    1649   int *SortIndex = (int *) Malloc(AtomCount*sizeof(int), "molecule::LinearInterpolationBetweenConfiguration: *SortIndex");
     1650  int *SortIndex = Malloc<int>(AtomCount, "molecule::LinearInterpolationBetweenConfiguration: *SortIndex");
    16501651  for (int i=AtomCount; i--; )
    16511652    SortIndex[i] = i;
     
    16531654 
    16541655  // free and return
    1655   Free((void **)&PermutationMap, "molecule::MinimiseConstrainedPotential: *PermutationMap");
     1656  Free(&PermutationMap);
    16561657  delete(MoleculePerStep);
    16571658  return status;
     
    17121713      ConstrainedPotentialEnergy = MinimiseConstrainedPotential(out, PermutationMap,configuration.DoConstrainedMD, 0, configuration.GetIsAngstroem());
    17131714      EvaluateConstrainedForces(out, configuration.DoConstrainedMD, 0, PermutationMap, &Force);
    1714       Free((void **)&PermutationMap, "molecule::MinimiseConstrainedPotential: *PermutationMap");
     1715      Free(&PermutationMap);
    17151716    }
    17161717   
     
    24122413        if (Walker->type->Z != 1) // count non-hydrogen atoms whilst at it
    24132414          NoNonHydrogen++;
    2414         Free((void **)&Walker->Name, "molecule::CountAtoms: *walker->Name");
    2415         Walker->Name = (char *) Malloc(sizeof(char)*6, "molecule::CountAtoms: *walker->Name");
     2415        Free(&Walker->Name);
     2416        Walker->Name = Malloc<char>(6, "molecule::CountAtoms: *walker->Name");
    24162417        sprintf(Walker->Name, "%2s%02d", Walker->type->symbol, Walker->nr+1);
    24172418        *out << "Naming atom nr. " << Walker->nr << " " << Walker->Name << "." << endl;
     
    26242625    NumberCells = divisor[0]*divisor[1]*divisor[2];
    26252626    *out << Verbose(1) << "Allocating " << NumberCells << " cells." << endl;
    2626     CellList = (molecule **) Malloc(sizeof(molecule *)*NumberCells, "molecule::CreateAdjacencyList - ** CellList");
     2627    CellList = Malloc<molecule*>(NumberCells, "molecule::CreateAdjacencyList - ** CellList");
    26272628    for (int i=NumberCells;i--;)
    26282629      CellList[i] = NULL;
     
    27062707        delete(CellList[i]);
    27072708      }
    2708     Free((void **)&CellList, "molecule::CreateAdjacencyList - ** CellList");
     2709    Free(&CellList);
    27092710
    27102711    // create the adjacency list per atom
     
    27712772    *out << Verbose(1) << "AtomCount is " << AtomCount << ", thus no bonds, no connections!." << endl;
    27722773  *out << Verbose(0) << "End of CreateAdjacencyList." << endl;
    2773   Free((void **)&matrix, "molecule::CreateAdjacencyList: *matrix");
     2774  Free(&matrix);
    27742775
    27752776};
     
    29812982void molecule::CyclicStructureAnalysis(ofstream *out, class StackClass<bond *> *  BackEdgeStack, int *&MinimumRingSize)
    29822983{
    2983   atom **PredecessorList = (atom **) Malloc(sizeof(atom *)*AtomCount, "molecule::CyclicStructureAnalysis: **PredecessorList");
    2984   int *ShortestPathList = (int *) Malloc(sizeof(int)*AtomCount, "molecule::CyclicStructureAnalysis: *ShortestPathList");
    2985   enum Shading *ColorList = (enum Shading *) Malloc(sizeof(enum Shading)*AtomCount, "molecule::CyclicStructureAnalysis: *ColorList");
     2984  atom **PredecessorList = Malloc<atom*>(AtomCount, "molecule::CyclicStructureAnalysis: **PredecessorList");
     2985  int *ShortestPathList = Malloc<int>(AtomCount, "molecule::CyclicStructureAnalysis: *ShortestPathList");
     2986  enum Shading *ColorList = Malloc<enum Shading>(AtomCount, "molecule::CyclicStructureAnalysis: *ColorList");
    29862987  class StackClass<atom *> *BFSStack = new StackClass<atom *> (AtomCount);   // will hold the current ring
    29872988  class StackClass<atom *> *TouchedStack = new StackClass<atom *> (AtomCount);   // contains all "touched" atoms (that need to be reset after BFS loop)
     
    31743175    *out << Verbose(1) << "No rings were detected in the molecular structure." << endl;
    31753176
    3176   Free((void **)&PredecessorList, "molecule::CyclicStructureAnalysis: **PredecessorList");
    3177   Free((void **)&ShortestPathList, "molecule::CyclicStructureAnalysis: **ShortestPathList");
    3178   Free((void **)&ColorList, "molecule::CyclicStructureAnalysis: **ColorList");
     3177  Free(&PredecessorList);
     3178  Free(&ShortestPathList);
     3179  Free(&ColorList);
    31793180  delete(BFSStack);
    31803181};
     
    32203221    Walker = Walker->next;
    32213222    if (Walker->ComponentNr != NULL)
    3222       Free((void **)&Walker->ComponentNr, "molecule::InitComponentNumbers: **Walker->ComponentNr");
    3223     Walker->ComponentNr = (int *) Malloc(sizeof(int)*NumberOfBondsPerAtom[Walker->nr], "molecule::InitComponentNumbers: *Walker->ComponentNr");
     3223      Free(&Walker->ComponentNr);
     3224    Walker->ComponentNr = Malloc<int>(NumberOfBondsPerAtom[Walker->nr], "molecule::InitComponentNumbers: *Walker->ComponentNr");
    32243225    for (int i=NumberOfBondsPerAtom[Walker->nr];i--;)
    32253226      Walker->ComponentNr[i] = -1;
     
    33443345  int NumberOfFragments = 0;
    33453346  double TEFactor;
    3346   char *filename = (char *) Malloc(sizeof(char)*MAXSTRINGSIZE, "molecule::ParseKeySetFile - filename");
     3347  char *filename = Malloc<char>(MAXSTRINGSIZE, "molecule::ParseKeySetFile - filename");
    33473348
    33483349  if (FragmentList == NULL) { // check list pointer
     
    33563357  if (InputFile != NULL) {
    33573358    // each line represents a new fragment
    3358     char *buffer = (char *) Malloc(sizeof(char)*MAXSTRINGSIZE, "molecule::ParseKeySetFile - *buffer");
     3359    char *buffer = Malloc<char>(MAXSTRINGSIZE, "molecule::ParseKeySetFile - *buffer");
    33593360    // 1. parse keysets and insert into temp. graph
    33603361    while (!InputFile.eof()) {
     
    33713372    InputFile.close();
    33723373    InputFile.clear();
    3373     Free((void **)&buffer, "molecule::ParseKeySetFile - *buffer");
     3374    Free(&buffer);
    33743375    *out << Verbose(1) << "done." << endl;
    33753376  } else {
     
    34043405
    34053406  // free memory
    3406   Free((void **)&filename, "molecule::ParseKeySetFile - filename");
     3407  Free(&filename);
    34073408
    34083409  return status;
     
    35113512  stringstream filename;
    35123513  bool status = true;
    3513   char *buffer = (char *) Malloc(sizeof(char)*MAXSTRINGSIZE, "molecule::CheckAdjacencyFileAgainstMolecule: *buffer");
     3514  char *buffer = Malloc<char>(MAXSTRINGSIZE, "molecule::CheckAdjacencyFileAgainstMolecule: *buffer");
    35143515
    35153516  filename << path << "/" << FRAGMENTPREFIX << ADJACENCYFILE;
     
    35193520    // allocate storage structure
    35203521    int NonMatchNumber = 0;   // will number of atoms with differing bond structure
    3521     int *CurrentBonds = (int *) Malloc(sizeof(int)*8, "molecule::CheckAdjacencyFileAgainstMolecule - CurrentBonds"); // contains parsed bonds of current atom
     3522    int *CurrentBonds = Malloc<int>(8, "molecule::CheckAdjacencyFileAgainstMolecule - CurrentBonds"); // contains parsed bonds of current atom
    35223523    int CurrentBondsOfAtom;
    35233524
     
    35643565    } else
    35653566      *out << Verbose(1) << "done: Not equal by " << NonMatchNumber << " atoms." << endl;
    3566     Free((void **)&CurrentBonds, "molecule::CheckAdjacencyFileAgainstMolecule - **CurrentBonds");
     3567    Free(&CurrentBonds);
    35673568  } else {
    35683569    *out << Verbose(1) << "Adjacency file not found." << endl;
     
    35703571  }
    35713572  *out << endl;
    3572   Free((void **)&buffer, "molecule::CheckAdjacencyFileAgainstMolecule: *buffer");
     3573  Free(&buffer);
    35733574
    35743575  return status;
     
    35983599      return false;
    35993600    // parse the EnergyPerFragment file
    3600     char *buffer = (char *) Malloc(sizeof(char)*MAXSTRINGSIZE, "molecule::CheckOrderAtSite: *buffer");
     3601    char *buffer = Malloc<char>(MAXSTRINGSIZE, "molecule::CheckOrderAtSite: *buffer");
    36013602    sprintf(buffer, "%s/%s%s.dat", path, FRAGMENTPREFIX, ENERGYPERFRAGMENT);
    36023603    InputFile.open(buffer, ios::in);
     
    37053706      }
    37063707    }
    3707     Free((void **)&buffer, "molecule::CheckOrderAtSite: *buffer");
     3708    Free(&buffer);
    37083709    // pick a given number of highest values and set AtomMask
    37093710  } else { // global increase of Bond Order
     
    37573758    return false;
    37583759  }
    3759   SortIndex = (int *) Malloc(sizeof(int)*AtomCount, "molecule::FragmentMolecule: *SortIndex");
     3760  SortIndex = Malloc<int>(AtomCount, "molecule::FragmentMolecule: *SortIndex");
    37603761  for(int i=AtomCount;i--;)
    37613762    SortIndex[i] = -1;
     
    38313832  // === compare it with adjacency file ===
    38323833  FragmentationToDo = FragmentationToDo && CheckAdjacencyFileAgainstMolecule(out, configuration->configpath, ListOfAtoms);
    3833   Free((void **)&ListOfAtoms, "molecule::FragmentMolecule - **ListOfAtoms");
     3834  Free(&ListOfAtoms);
    38343835
    38353836  // ===== 2. perform a DFS analysis to gather info on cyclic structure and a list of disconnected subgraphs =====
     
    39203921    delete(Subgraphs);
    39213922  }
    3922   Free((void **)&FragmentList, "molecule::FragmentMolecule - **FragmentList");
     3923  Free(&FragmentList);
    39233924
    39243925  // ===== 8b. gather keyset lists (graphs) from all subgraphs and transform into MoleculeListClass =====
     
    39673968      *out << Verbose(1) << "Freeing bond memory" << endl;
    39683969      delete(FragmentList); // remove bond molecule from memory
    3969       Free((void **)&SortIndex, "molecule::FragmentMolecule: *SortIndex");
     3970      Free(&SortIndex);
    39703971    } else
    39713972      *out << Verbose(1) << "FragmentList is zero on return, splitting failed." << endl;
     
    40554056bool molecule::ParseOrderAtSiteFromFile(ofstream *out, char *path)
    40564057{
    4057   unsigned char *OrderArray = (unsigned char *) Malloc(sizeof(unsigned char)*AtomCount, "molecule::ParseOrderAtSiteFromFile - *OrderArray");
    4058   bool *MaxArray = (bool *) Malloc(sizeof(bool)*AtomCount, "molecule::ParseOrderAtSiteFromFile - *MaxArray");
     4058  unsigned char *OrderArray = Malloc<unsigned char>(AtomCount, "molecule::ParseOrderAtSiteFromFile - *OrderArray");
     4059  bool *MaxArray = Malloc<bool>(AtomCount, "molecule::ParseOrderAtSiteFromFile - *MaxArray");
    40594060  bool status;
    40604061  int AtomNr, value;
     
    40974098    status = false;
    40984099  }
    4099   Free((void **)&OrderArray, "molecule::ParseOrderAtSiteFromFile - *OrderArray");
    4100   Free((void **)&MaxArray, "molecule::ParseOrderAtSiteFromFile - *MaxArray");
     4100  Free(&OrderArray);
     4101  Free(&MaxArray);
    41014102
    41024103  *out << Verbose(1) << "End of ParseOrderAtSiteFromFile" << endl;
     
    41214122  if (ListOfBondsPerAtom != NULL) {
    41224123    for(int i=AtomCount;i--;)
    4123       Free((void **)&ListOfBondsPerAtom[i], "molecule::CreateListOfBondsPerAtom: ListOfBondsPerAtom[i]");
    4124     Free((void **)&ListOfBondsPerAtom, "molecule::CreateListOfBondsPerAtom: ListOfBondsPerAtom");
     4124      Free(&ListOfBondsPerAtom[i]);
     4125    Free(&ListOfBondsPerAtom);
    41254126  }
    41264127  if (NumberOfBondsPerAtom != NULL)
    4127     Free((void **)&NumberOfBondsPerAtom, "molecule::CreateListOfBondsPerAtom: NumberOfBondsPerAtom");
    4128   ListOfBondsPerAtom = (bond ***) Malloc(sizeof(bond **)*AtomCount, "molecule::CreateListOfBondsPerAtom: ***ListOfBondsPerAtom");
    4129   NumberOfBondsPerAtom = (int *) Malloc(sizeof(int)*AtomCount, "molecule::CreateListOfBondsPerAtom: *NumberOfBondsPerAtom");
     4128    Free(&NumberOfBondsPerAtom);
     4129  ListOfBondsPerAtom = Malloc<bond**>(AtomCount, "molecule::CreateListOfBondsPerAtom: ***ListOfBondsPerAtom");
     4130  NumberOfBondsPerAtom = Malloc<int>(AtomCount, "molecule::CreateListOfBondsPerAtom: *NumberOfBondsPerAtom");
    41304131
    41314132  // reset bond counts per atom
     
    41414142  for(int i=AtomCount;i--;) {
    41424143    // allocate list of bonds per atom
    4143     ListOfBondsPerAtom[i] = (bond **) Malloc(sizeof(bond *)*NumberOfBondsPerAtom[i], "molecule::CreateListOfBondsPerAtom: **ListOfBondsPerAtom[]");
     4144    ListOfBondsPerAtom[i] = Malloc<bond*>(NumberOfBondsPerAtom[i], "molecule::CreateListOfBondsPerAtom: **ListOfBondsPerAtom[]");
    41444145    // clear the list again, now each NumberOfBondsPerAtom marks current free field
    41454146    NumberOfBondsPerAtom[i] = 0;
     
    41834184void molecule::BreadthFirstSearchAdd(ofstream *out, molecule *Mol, atom **&AddedAtomList, bond **&AddedBondList, atom *Root, bond *Bond, int BondOrder, bool IsAngstroem)
    41844185{
    4185   atom **PredecessorList = (atom **) Malloc(sizeof(atom *)*AtomCount, "molecule::BreadthFirstSearchAdd: **PredecessorList");
    4186   int *ShortestPathList = (int *) Malloc(sizeof(int)*AtomCount, "molecule::BreadthFirstSearchAdd: *ShortestPathList");
    4187   enum Shading *ColorList = (enum Shading *) Malloc(sizeof(enum Shading)*AtomCount, "molecule::BreadthFirstSearchAdd: *ColorList");
     4186  atom **PredecessorList = Malloc<atom*>(AtomCount, "molecule::BreadthFirstSearchAdd: **PredecessorList");
     4187  int *ShortestPathList = Malloc<int>(AtomCount, "molecule::BreadthFirstSearchAdd: *ShortestPathList");
     4188  enum Shading *ColorList = Malloc<enum Shading>(AtomCount, "molecule::BreadthFirstSearchAdd: *ColorList");
    41884189  class StackClass<atom *> *AtomStack = new StackClass<atom *>(AtomCount);
    41894190  atom *Walker = NULL, *OtherAtom = NULL;
     
    42904291    *out << Verbose(1) << "Coloring Walker " << Walker->Name << " black." << endl;
    42914292  }
    4292   Free((void **)&PredecessorList, "molecule::BreadthFirstSearchAdd: **PredecessorList");
    4293   Free((void **)&ShortestPathList, "molecule::BreadthFirstSearchAdd: **ShortestPathList");
    4294   Free((void **)&ColorList, "molecule::BreadthFirstSearchAdd: **ColorList");
     4293  Free(&PredecessorList);
     4294  Free(&ShortestPathList);
     4295  Free(&ColorList);
    42954296  delete(AtomStack);
    42964297};
     
    43094310  atom *Walker = NULL, *OtherAtom = NULL;
    43104311  bool status = true;
    4311   atom **ParentList = (atom **) Malloc(sizeof(atom *)*Father->AtomCount, "molecule::BuildInducedSubgraph: **ParentList");
     4312  atom **ParentList = Malloc<atom*>(Father->AtomCount, "molecule::BuildInducedSubgraph: **ParentList");
    43124313
    43134314  *out << Verbose(2) << "Begin of BuildInducedSubgraph." << endl;
     
    43484349  }
    43494350
    4350   Free((void **)&ParentList, "molecule::BuildInducedSubgraph: **ParentList");
     4351  Free(&ParentList);
    43514352  *out << Verbose(2) << "End of BuildInducedSubgraph." << endl;
    43524353  return status;
     
    43914392{
    43924393  atom *Runner = NULL, *FatherOfRunner = NULL, *OtherFather = NULL;
    4393   atom **SonList = (atom **) Malloc(sizeof(atom *)*AtomCount, "molecule::StoreFragmentFromStack: **SonList");
     4394  atom **SonList = Malloc<atom*>(AtomCount, "molecule::StoreFragmentFromStack: **SonList");
    43944395  molecule *Leaf = new molecule(elemente);
    43954396  bool LonelyFlag = false;
     
    44614462  Leaf->CreateListOfBondsPerAtom(out);
    44624463  //Leaflet->Leaf->ScanForPeriodicCorrection(out);
    4463   Free((void **)&SonList, "molecule::StoreFragmentFromStack: **SonList");
     4464  Free(&SonList);
    44644465//  *out << Verbose(1) << "End of StoreFragmentFromKeyset." << endl;
    44654466  return Leaf;
     
    44824483MoleculeListClass * molecule::CreateListOfUniqueFragmentsOfOrder(ofstream *out, int Order, config *configuration)
    44834484{
    4484   atom **PredecessorList = (atom **) Malloc(sizeof(atom *)*AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: **PredecessorList");
    4485   int *ShortestPathList = (int *) Malloc(sizeof(int)*AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *ShortestPathList");
    4486   int *Labels = (int *) Malloc(sizeof(int)*AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *Labels");
    4487   enum Shading *ColorVertexList = (enum Shading *) Malloc(sizeof(enum Shading)*AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *ColorList");
    4488   enum Shading *ColorEdgeList = (enum Shading *) Malloc(sizeof(enum Shading)*BondCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *ColorBondList");
     4485  atom **PredecessorList = Malloc<atom*>(AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: **PredecessorList");
     4486  int *ShortestPathList = Malloc<int>(AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *ShortestPathList");
     4487  int *Labels = Malloc<int>(AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *Labels");
     4488  enum Shading *ColorVertexList = Malloc<enum Shading>(AtomCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *ColorList");
     4489  enum Shading *ColorEdgeList = Malloc<enum Shading>(BondCount, "molecule::CreateListOfUniqueFragmentsOfOrder: *ColorBondList");
    44894490  StackClass<atom *> *RootStack = new StackClass<atom *>(AtomCount);
    44904491  StackClass<atom *> *TouchedStack = new StackClass<atom *>((int)pow(4,Order)+2); // number of atoms reached from one with maximal 4 bonds plus Root itself
     
    46164617
    46174618  // free memory and exit
    4618   Free((void **)&PredecessorList, "molecule::CreateListOfUniqueFragmentsOfOrder: **PredecessorList");
    4619   Free((void **)&ShortestPathList, "molecule::CreateListOfUniqueFragmentsOfOrder: *ShortestPathList");
    4620   Free((void **)&Labels, "molecule::CreateListOfUniqueFragmentsOfOrder: *Labels");
    4621   Free((void **)&ColorVertexList, "molecule::CreateListOfUniqueFragmentsOfOrder: *ColorList");
     4619  Free(&PredecessorList);
     4620  Free(&ShortestPathList);
     4621  Free(&Labels);
     4622  Free(&ColorVertexList);
    46224623  delete(RootStack);
    46234624  delete(TouchedStack);
     
    46694670  int Removal;
    46704671  int SpaceLeft;
    4671   int *TouchedList = (int *) Malloc(sizeof(int)*(SubOrder+1), "molecule::SPFragmentGenerator: *TouchedList");
     4672  int *TouchedList = Malloc<int>(SubOrder + 1, "molecule::SPFragmentGenerator: *TouchedList");
    46724673  bond *Binder = NULL;
    46734674  bond **BondsList = NULL;
     
    46774678
    46784679  // Hier muessen von 1 bis NumberOfBondsPerAtom[Walker->nr] alle Kombinationen
    4679   // von Endstuecken (aus den Bonds) hinzugefᅵᅵgt werden und fᅵᅵr verbleibende ANOVAOrder
    4680   // rekursiv GraphCrawler in der nᅵᅵchsten Ebene aufgerufen werden
     4680  // von Endstuecken (aus den Bonds) hinzugefuegt werden und fuer verbleibende ANOVAOrder
     4681  // rekursiv GraphCrawler in der naechsten Ebene aufgerufen werden
    46814682
    46824683  *out << Verbose(1+verbosity) << "Begin of SPFragmentGenerator." << endl;
     
    47384739          }
    47394740          // then allocate and fill the list
    4740           BondsList = (bond **) Malloc(sizeof(bond *)*SubSetDimension, "molecule::SPFragmentGenerator: **BondsList");
     4741          BondsList = Malloc<bond*>(SubSetDimension, "molecule::SPFragmentGenerator: **BondsList");
    47414742          SubSetDimension = 0;
    47424743          Binder = FragmentSearch->BondsPerSPList[2*SP];
     
    47504751          *out << Verbose(2+verbosity) << "Calling subset generator " << SP << " away from root " << *FragmentSearch->Root << " with sub set dimension " << SubSetDimension << "." << endl;
    47514752          SPFragmentGenerator(out, FragmentSearch, SP, BondsList, SubSetDimension, SubOrder-bits);
    4752           Free((void **)&BondsList, "molecule::SPFragmentGenerator: **BondsList");
     4753          Free(&BondsList);
    47534754        }
    47544755      } else {
     
    47844785    }
    47854786  }
    4786   Free((void **)&TouchedList, "molecule::SPFragmentGenerator: *TouchedList");
     4787  Free(&TouchedList);
    47874788  *out << Verbose(1+verbosity) << "End of SPFragmentGenerator, " << RootDistance << " away from Root " << *FragmentSearch->Root << " and SubOrder is " << SubOrder << "." << endl;
    47884789};
     
    49624963    *out << Verbose(0) << "Preparing subset for this root and calling generator." << endl;
    49634964    // prepare the subset and call the generator
    4964     BondsList = (bond **) Malloc(sizeof(bond *)*FragmentSearch.BondsPerSPCount[0], "molecule::PowerSetGenerator: **BondsList");
     4965    BondsList = Malloc<bond*>(FragmentSearch.BondsPerSPCount[0], "molecule::PowerSetGenerator: **BondsList");
    49654966    BondsList[0] = FragmentSearch.BondsPerSPList[0]->next;  // on SP level 0 there's only the root bond
    49664967
    49674968    SPFragmentGenerator(out, &FragmentSearch, 0, BondsList, FragmentSearch.BondsPerSPCount[0], Order);
    49684969
    4969     Free((void **)&BondsList, "molecule::PowerSetGenerator: **BondsList");
     4970    Free(&BondsList);
    49704971  } else {
    49714972    *out << Verbose(0) << "Not enough total number of edges to build " << Order << "-body fragments." << endl;
     
    50215022  *out << Verbose(2) << "Begin of ScanForPeriodicCorrection." << endl;
    50225023
    5023   ColorList = (enum Shading *) Malloc(sizeof(enum Shading)*AtomCount, "molecule::ScanForPeriodicCorrection: *ColorList");
     5024  ColorList = Malloc<enum Shading>(AtomCount, "molecule::ScanForPeriodicCorrection: *ColorList");
    50245025  while (flag) {
    50255026    // remove bonds that are beyond bonddistance
     
    50825083  // free allocated space from ReturnFullMatrixforSymmetric()
    50835084  delete(AtomStack);
    5084   Free((void **)&ColorList, "molecule::ScanForPeriodicCorrection: *ColorList");
    5085   Free((void **)&matrix, "molecule::ScanForPeriodicCorrection: *matrix");
     5085  Free(&ColorList);
     5086  Free(&matrix);
    50865087  *out << Verbose(2) << "End of ScanForPeriodicCorrection." << endl;
    50875088};
     
    50935094double * molecule::ReturnFullMatrixforSymmetric(double *symm)
    50945095{
    5095   double *matrix = (double *) Malloc(sizeof(double)*NDIM*NDIM, "molecule::ReturnFullMatrixforSymmetric: *matrix");
     5096  double *matrix = Malloc<double>(NDIM * NDIM, "molecule::ReturnFullMatrixforSymmetric: *matrix");
    50965097  matrix[0] = symm[0];
    50975098  matrix[1] = symm[1];
     
    52205221  // FragmentLowerOrdersList is a 2D-array of pointer to MoleculeListClass objects, one dimension represents the ANOVA expansion of a single order (i.e. 5)
    52215222  // with all needed lower orders that are subtracted, the other dimension is the BondOrder (i.e. from 1 to 5)
    5222   NumMoleculesOfOrder = (int *) Malloc(sizeof(int)*UpgradeCount, "molecule::FragmentBOSSANOVA: *NumMoleculesOfOrder");
    5223   FragmentLowerOrdersList = (Graph ***) Malloc(sizeof(Graph **)*UpgradeCount, "molecule::FragmentBOSSANOVA: ***FragmentLowerOrdersList");
     5223  NumMoleculesOfOrder = Malloc<int>(UpgradeCount, "molecule::FragmentBOSSANOVA: *NumMoleculesOfOrder");
     5224  FragmentLowerOrdersList = Malloc<Graph**>(UpgradeCount, "molecule::FragmentBOSSANOVA: ***FragmentLowerOrdersList");
    52245225
    52255226  // initialise the fragments structure
    5226   FragmentSearch.ShortestPathList = (int *) Malloc(sizeof(int)*AtomCount, "molecule::PowerSetGenerator: *ShortestPathList");
     5227  FragmentSearch.ShortestPathList = Malloc<int>(AtomCount, "molecule::PowerSetGenerator: *ShortestPathList");
    52275228  FragmentSearch.FragmentCounter = 0;
    52285229  FragmentSearch.FragmentSet = new KeySet;
     
    52595260
    52605261      // initialise Order-dependent entries of UniqueFragments structure
    5261       FragmentSearch.BondsPerSPList = (bond **) Malloc(sizeof(bond *)*Order*2, "molecule::PowerSetGenerator: ***BondsPerSPList");
    5262       FragmentSearch.BondsPerSPCount = (int *) Malloc(sizeof(int)*Order, "molecule::PowerSetGenerator: *BondsPerSPCount");
     5262      FragmentSearch.BondsPerSPList = Malloc<bond*>(Order * 2, "molecule::PowerSetGenerator: ***BondsPerSPList");
     5263      FragmentSearch.BondsPerSPCount = Malloc<int>(Order, "molecule::PowerSetGenerator: *BondsPerSPCount");
    52635264      for (int i=Order;i--;) {
    52645265        FragmentSearch.BondsPerSPList[2*i] = new bond();    // start node
     
    52715272      // allocate memory for all lower level orders in this 1D-array of ptrs
    52725273      NumLevels = 1 << (Order-1); // (int)pow(2,Order);
    5273       FragmentLowerOrdersList[RootNr] = (Graph **) Malloc(sizeof(Graph *)*NumLevels, "molecule::FragmentBOSSANOVA: **FragmentLowerOrdersList[]");
     5274      FragmentLowerOrdersList[RootNr] = Malloc<Graph*>(NumLevels, "molecule::FragmentBOSSANOVA: **FragmentLowerOrdersList[]");
    52745275      for (int i=0;i<NumLevels;i++)
    52755276        FragmentLowerOrdersList[RootNr][i] = NULL;
     
    53385339
    53395340      // free Order-dependent entries of UniqueFragments structure for next loop cycle
    5340       Free((void **)&FragmentSearch.BondsPerSPCount, "molecule::PowerSetGenerator: *BondsPerSPCount");
     5341      Free(&FragmentSearch.BondsPerSPCount);
    53415342      for (int i=Order;i--;) {
    53425343        delete(FragmentSearch.BondsPerSPList[2*i]);
    53435344        delete(FragmentSearch.BondsPerSPList[2*i+1]);
    53445345      }
    5345       Free((void **)&FragmentSearch.BondsPerSPList, "molecule::PowerSetGenerator: ***BondsPerSPList");
     5346      Free(&FragmentSearch.BondsPerSPList);
    53465347    }
    53475348  }
     
    53515352
    53525353  // cleanup FragmentSearch structure
    5353   Free((void **)&FragmentSearch.ShortestPathList, "molecule::PowerSetGenerator: *ShortestPathList");
     5354  Free(&FragmentSearch.ShortestPathList);
    53545355  delete(FragmentSearch.FragmentSet);
    53555356
     
    53825383      }
    53835384    }
    5384     Free((void **)&FragmentLowerOrdersList[RootNr], "molecule::FragmentBOSSANOVA: **FragmentLowerOrdersList[]");
     5385    Free(&FragmentLowerOrdersList[RootNr]);
    53855386    RootNr++;
    53865387  }
    5387   Free((void **)&FragmentLowerOrdersList, "molecule::FragmentBOSSANOVA: ***FragmentLowerOrdersList");
    5388   Free((void **)&NumMoleculesOfOrder, "molecule::FragmentBOSSANOVA: *NumMoleculesOfOrder");
     5388  Free(&FragmentLowerOrdersList);
     5389  Free(&NumMoleculesOfOrder);
    53895390
    53905391  *out << Verbose(0) << "End of FragmentBOSSANOVA." << endl;
     
    54765477  if (result) {
    54775478    *out << Verbose(5) << "Calculating distances" << endl;
    5478     Distances = (double *) Malloc(sizeof(double)*AtomCount, "molecule::IsEqualToWithinThreshold: Distances");
    5479     OtherDistances = (double *) Malloc(sizeof(double)*AtomCount, "molecule::IsEqualToWithinThreshold: OtherDistances");
     5479    Distances = Malloc<double>(AtomCount, "molecule::IsEqualToWithinThreshold: Distances");
     5480    OtherDistances = Malloc<double>(AtomCount, "molecule::IsEqualToWithinThreshold: OtherDistances");
    54805481    Walker = start;
    54815482    while (Walker->next != end) {
     
    54915492    /// ... sort each list (using heapsort (o(N log N)) from GSL)
    54925493    *out << Verbose(5) << "Sorting distances" << endl;
    5493     PermMap = (size_t *) Malloc(sizeof(size_t)*AtomCount, "molecule::IsEqualToWithinThreshold: *PermMap");
    5494     OtherPermMap = (size_t *) Malloc(sizeof(size_t)*AtomCount, "molecule::IsEqualToWithinThreshold: *OtherPermMap");
     5494    PermMap = Malloc<size_t>(AtomCount, "molecule::IsEqualToWithinThreshold: *PermMap");
     5495    OtherPermMap = Malloc<size_t>(AtomCount, "molecule::IsEqualToWithinThreshold: *OtherPermMap");
    54955496    gsl_heapsort_index (PermMap, Distances, AtomCount, sizeof(double), CompareDoubles);
    54965497    gsl_heapsort_index (OtherPermMap, OtherDistances, AtomCount, sizeof(double), CompareDoubles);
    5497     PermutationMap = (int *) Malloc(sizeof(int)*AtomCount, "molecule::IsEqualToWithinThreshold: *PermutationMap");
     5498    PermutationMap = Malloc<int>(AtomCount, "molecule::IsEqualToWithinThreshold: *PermutationMap");
    54985499    *out << Verbose(5) << "Combining Permutation Maps" << endl;
    54995500    for(int i=AtomCount;i--;)
    55005501      PermutationMap[PermMap[i]] = (int) OtherPermMap[i];
    55015502
    5502     /// ... and compare them step by step, whether the difference is individiually(!) below \a threshold for all
     5503    /// ... and compare them step by step, whether the difference is individually(!) below \a threshold for all
    55035504    *out << Verbose(4) << "Comparing distances" << endl;
    55045505    flag = 0;
     
    55085509        flag = 1;
    55095510    }
    5510     Free((void **)&PermMap, "molecule::IsEqualToWithinThreshold: *PermMap");
    5511     Free((void **)&OtherPermMap, "molecule::IsEqualToWithinThreshold: *OtherPermMap");
    5512 
    5513     /// free memory
    5514     Free((void **)&Distances, "molecule::IsEqualToWithinThreshold: Distances");
    5515     Free((void **)&OtherDistances, "molecule::IsEqualToWithinThreshold: OtherDistances");
     5511
     5512    // free memory
     5513    Free(&PermMap);
     5514    Free(&OtherPermMap);
     5515    Free(&Distances);
     5516    Free(&OtherDistances);
    55165517    if (flag) { // if not equal
    5517       Free((void **)&PermutationMap, "molecule::IsEqualToWithinThreshold: *PermutationMap");
     5518      Free(&PermutationMap);
    55185519      result = false;
    55195520    }
     
    55415542  atom *Walker = NULL, *OtherWalker = NULL;
    55425543  *out << Verbose(3) << "Begin of GetFatherAtomicMap." << endl;
    5543   int *AtomicMap = (int *) Malloc(sizeof(int)*AtomCount, "molecule::GetAtomicMap: *AtomicMap");  //Calloc
     5544  int *AtomicMap = Malloc<int>(AtomCount, "molecule::GetAtomicMap: *AtomicMap");
    55445545  for (int i=AtomCount;i--;)
    55455546    AtomicMap[i] = -1;
Note: See TracChangeset for help on using the changeset viewer.