Ignore:
Timestamp:
Jun 12, 2016, 8:48:21 AM (9 years ago)
Author:
Frederik Heber <heber@…>
Branches:
Fix_BoundInBox_CenterInBox_MoleculeActions
Parents:
996ef1
git-author:
Frederik Heber <heber@…> (06/11/16 16:43:54)
git-committer:
Frederik Heber <heber@…> (06/12/16 08:48:21)
Message:

FIX: CenterInBox and BoundInBox are actions acting on molecules, not world.

  • just stumbled over this when realizing that center-in-box does not center all selected atoms within the box but each of the currently present molecules individually.
  • this is also changed to act only on selected molecules.
  • TEST: extended regression test to only test centering and bounding of some molecules (and not only all).
  • TESTFIX: needed to change regression tests on all molecules to prepend action with select-all-molecules.
  • Needed to renamed python action in boxmaker.py.in.
  • DOCU: Corrected description in userguide.
File:
1 moved

Legend:

Unmodified
Added
Removed
  • tests/regression/Domain/BoundInBox/testsuite-domain-bound-in-box-allmolecules.at

    r996ef1 r25d9d9  
    1818### bound atoms in defined domain
    1919
    20 AT_SETUP([Domain - bounding in domain])
     20AT_SETUP([Domain - bounding in domain all molecules])
    2121AT_KEYWORDS([domain bound-in-box])
    2222
     
    2424AT_CHECK([/bin/cp -f ${abs_top_srcdir}/tests/regression/Domain/BoundInBox/pre/test.conf $file], 0)
    2525AT_CHECK([chmod u+w $file], 0)
    26 AT_CHECK([../../molecuilder -i $file --bound-in-box], 0, [stdout], [stderr])
     26AT_CHECK([../../molecuilder -i $file --select-all-molecules --bound-in-box], 0, [stdout], [stderr])
    2727AT_CHECK([diff $file ${abs_top_srcdir}/tests/regression/Domain/BoundInBox/post/test.conf], 0, [stdout], [stderr])
    2828
     
    3030
    3131
    32 AT_SETUP([Domain - bounding in domain with Undo])
     32AT_SETUP([Domain - bounding in domain all molecules with Undo])
    3333AT_KEYWORDS([domain bound-in-box undo])
    3434
     
    3636AT_CHECK([/bin/cp -f ${abs_top_srcdir}/tests/regression/Domain/BoundInBox/pre/test.conf $file], 0)
    3737AT_CHECK([chmod u+w $file], 0)
    38 AT_CHECK([../../molecuilder -i $file --bound-in-box --undo], 0, [stdout], [stderr])
     38AT_CHECK([../../molecuilder -i $file --select-all-molecules --bound-in-box --undo], 0, [stdout], [stderr])
    3939AT_CHECK([diff $file ${abs_top_srcdir}/tests/regression/Domain/BoundInBox/post/test-undo.conf], 0, [stdout], [stderr])
    4040
     
    4242
    4343
    44 AT_SETUP([Domain - bounding in domain with Redo])
     44AT_SETUP([Domain - bounding in domain all molecules with Redo])
    4545AT_KEYWORDS([domain bound-in-box redo])
    4646
     
    4848AT_CHECK([/bin/cp -f ${abs_top_srcdir}/tests/regression/Domain/BoundInBox/pre/test.conf $file], 0)
    4949AT_CHECK([chmod u+w $file], 0)
    50 AT_CHECK([../../molecuilder -i $file --bound-in-box --undo --redo], 0, [stdout], [stderr])
     50AT_CHECK([../../molecuilder -i $file --select-all-molecules --bound-in-box --undo --redo], 0, [stdout], [stderr])
    5151AT_CHECK([diff $file ${abs_top_srcdir}/tests/regression/Domain/BoundInBox/post/test.conf], 0, [stdout], [stderr])
    5252
Note: See TracChangeset for help on using the changeset viewer.