Ignore:
Timestamp:
Jun 12, 2016, 8:48:21 AM (9 years ago)
Author:
Frederik Heber <heber@…>
Branches:
Fix_BoundInBox_CenterInBox_MoleculeActions
Parents:
996ef1
git-author:
Frederik Heber <heber@…> (06/11/16 16:43:54)
git-committer:
Frederik Heber <heber@…> (06/12/16 08:48:21)
Message:

FIX: CenterInBox and BoundInBox are actions acting on molecules, not world.

  • just stumbled over this when realizing that center-in-box does not center all selected atoms within the box but each of the currently present molecules individually.
  • this is also changed to act only on selected molecules.
  • TEST: extended regression test to only test centering and bounding of some molecules (and not only all).
  • TESTFIX: needed to change regression tests on all molecules to prepend action with select-all-molecules.
  • Needed to renamed python action in boxmaker.py.in.
  • DOCU: Corrected description in userguide.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • src/Actions/Makefile.am

    r996ef1 r25d9d9  
    301301MOLECULEACTIONSOURCE = \
    302302  Actions/MoleculeAction/BondFileAction.cpp \
     303  Actions/MoleculeAction/BoundInBoxAction.cpp \
     304  Actions/MoleculeAction/CenterInBoxAction.cpp \
    303305  Actions/MoleculeAction/ChangeBondAngleAction.cpp \
    304306  Actions/MoleculeAction/ChangeNameAction.cpp \
     
    319321MOLECULEACTIONHEADER = \
    320322  Actions/MoleculeAction/BondFileAction.hpp \
     323  Actions/MoleculeAction/BoundInBoxAction.hpp \
     324  Actions/MoleculeAction/CenterInBoxAction.hpp \
    321325  Actions/MoleculeAction/ChangeBondAngleAction.hpp \
    322326  Actions/MoleculeAction/ChangeNameAction.hpp \
     
    337341MOLECULEACTIONDEFS = \
    338342  Actions/MoleculeAction/BondFileAction.def \
     343  Actions/MoleculeAction/BoundInBoxAction.def \
     344  Actions/MoleculeAction/CenterInBoxAction.def \
    339345  Actions/MoleculeAction/ChangeBondAngleAction.def \
    340346  Actions/MoleculeAction/ChangeNameAction.def \
     
    579585WORLDACTIONSOURCE = \
    580586  Actions/WorldAction/AddEmptyBoundaryAction.cpp \
    581   Actions/WorldAction/BoundInBoxAction.cpp \
    582   Actions/WorldAction/CenterInBoxAction.cpp \
    583587  Actions/WorldAction/CenterOnEdgeAction.cpp \
    584588  Actions/WorldAction/ChangeBoxAction.cpp \
     
    593597WORLDACTIONHEADER = \
    594598  Actions/WorldAction/AddEmptyBoundaryAction.hpp \
    595   Actions/WorldAction/BoundInBoxAction.hpp \
    596   Actions/WorldAction/CenterInBoxAction.hpp \
    597599  Actions/WorldAction/CenterOnEdgeAction.hpp \
    598600  Actions/WorldAction/ChangeBoxAction.hpp \
     
    607609WORLDACTIONDEFS = \
    608610  Actions/WorldAction/AddEmptyBoundaryAction.def \
    609   Actions/WorldAction/BoundInBoxAction.def \
    610   Actions/WorldAction/CenterInBoxAction.def \
    611611  Actions/WorldAction/CenterOnEdgeAction.def \
    612612  Actions/WorldAction/ChangeBoxAction.def \
Note: See TracChangeset for help on using the changeset viewer.