Changeset 1e242a for src/Potentials/Specifics/unittests/PairPotential_AngleUnitTest.cpp

Timestamp:

Jul 8, 2013, 2:22:02 PM (12 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

b15ae7

Parents:

065a16

git-author:

Frederik Heber <heber@…> (05/09/13 13:46:01)

git-committer:

Frederik Heber <heber@…> (07/08/13 14:22:02)

Message:

Removed energy_offset from PairPotential_Angle.

• regression test FitPotential with harmonic_angle potential marked as XFAIL. This is required until we use new CompoundPotential in FitPotentialAction.

File:

• src/Potentials/Specifics/unittests/PairPotential_AngleUnitTest.cpp (modified) (6 diffs)

src/Potentials/Specifics/unittests/PairPotential_AngleUnitTest.cpp

@@ -61 +61 @@
 
 const double spring_constant = .5;
-const double offset = .1;
 
 void PairPotential_AngleTest::setUp()
@@ -81 +80 @@
   }
   output +=
-      spring_constant*0.25+offset,
-      spring_constant*0.16+offset,
-      spring_constant*0.09+offset,
-      spring_constant*0.04+offset,
-      spring_constant*0.01+offset,
-      spring_constant*0.+offset,
-      spring_constant*0.01+offset,
-      spring_constant*0.04+offset,
-      spring_constant*0.09+offset,
-      spring_constant*0.16+offset,
-      spring_constant*0.25+offset;
+      spring_constant*0.25,
+      spring_constant*0.16,
+      spring_constant*0.09,
+      spring_constant*0.04,
+      spring_constant*0.01,
+      spring_constant*0.,
+      spring_constant*0.01,
+      spring_constant*0.04,
+      spring_constant*0.09,
+      spring_constant*0.16,
+      spring_constant*0.25;
 
   CPPUNIT_ASSERT_EQUAL( input.size(), output.size() );
@@ -109 +108 @@
         (0)(1)(1)
       ;
-  PairPotential_Angle angle(types, spring_constant,0.,offset);
+  PairPotential_Angle angle(types, spring_constant,0.);
   for (size_t index = 0; index < input.size(); ++index) {
     const PairPotential_Angle::results_t result =
@@ -130 +129 @@
         (0)(1)(1)
       ;
-  PairPotential_Angle angle(types, spring_constant,0.,offset);
+  PairPotential_Angle angle(types, spring_constant,0.);
   CPPUNIT_ASSERT(
       Helpers::isEqual(
@@ -151 +150 @@
         (0)(1)(1)
       ;
-  PairPotential_Angle angle(types, spring_constant,0.,offset);
+  PairPotential_Angle angle(types, spring_constant,0.);
   CPPUNIT_ASSERT(
       Helpers::isEqual(
@@ -172 +171 @@
       )
   );
-  CPPUNIT_ASSERT(
-      Helpers::isEqual(
-          1.,
-          angle.parameter_derivative(
-              input[5],
-              2
-          )[0],
-          10.
-      )
-  );
 }