Changeset 06f141 for molecuilder/src/unittests/LinkedCellUnitTest.cpp

Timestamp:

May 18, 2010, 3:20:52 PM (16 years ago)

Author:

Frederik Heber <heber@…>

Children:

108d38

Parents:

7a6fd9

Message:

"-e <db path>" not necessary anymore.

Removed necessity of specifying path to databases (this was one check of molecuilder/test/testsuite.at which cannot be fulfilled anymore with boost::program_options)
For this to work a great number of small changes have been necessary:

class periodentafel:

• all .db files merged into const char * arrays in elements_db.cpp
• periodentafel rewritten:
  • each database has its own function and uses a istream: LoadElementsDatabase(), LoadValenceDatabase(), LoadOrbitalsDatabase(), LoadHBondAngleDatabase(), LoadHBondLengthsDatabase()
  • constructor periodentafel::LoadPeriodentafel() calls each function on the above const char * arrays
  • it is still possible to call LoadPeriodentafel with an external path.
• FindElement(), AskElement() and EnterElement return element * const instead of const element * (i.e. the contents of the pointer is const (the element) not the pointer itself which is very vexatious (i.e. FindElement() yields const element * which can subsequently not be used for RemoveElement(), ...)
• parsedElems is not needed anymore. Instead we operate on map elements directly
• new unittest periodentafelTest which is made friend of periodentafel to be able to access private loading functions directly

A number of unit tests had to be changed (all that create elements during setUp() which is now unnecessary)

• element creation removed: AnalysisCorrelationToPointUnitTest, AnalysisCorrelationToSurfaceUnitTest, AnalysisPairCorrelationUnitTest, CountBondsTest, LinkedCellTest, ParserUnitTest, AnalysisBondsTest, BondGraphTest, ListOfBondsTest
• adapted parsed bond table (carbon is no Z=6 not 2): AnalysisBondsTest, BondGraphTest

Some of the analysis_bonds function's signatures were changed in the process:

• have const element * instead of element *: MinMeanMaxBondDistanceBetweenElements(), CountHydrogenBridgeBonds()

Finally, the respective tests are removed from molecuilder/tests/testsuite.at.

File:

• molecuilder/src/unittests/LinkedCellUnitTest.cpp (modified) (2 diffs)

molecuilder/src/unittests/LinkedCellUnitTest.cpp

@@ -38 +38 @@
   atom *Walker = NULL;
 
-  // init private all pointers to zero
-  TestMolecule = NULL;
-  hydrogen = NULL;
-  tafel = NULL;
-
   // construct element
-  hydrogen = new element;
-  hydrogen->Z = 1;
-  hydrogen->CovalentRadius = 0.23;
-  strcpy(hydrogen->name, "hydrogen");
-  strcpy(hydrogen->symbol, "H");
-
-  // construct periodentafel
-  tafel = World::getInstance().getPeriode();
-  tafel->AddElement(hydrogen);
+  hydrogen = World::getInstance().getPeriode()->FindElement(1);
+  CPPUNIT_ASSERT(hydrogen != NULL && "could not find element hydrogen");
 
   // construct molecule (water molecule)
   TestMolecule = World::getInstance().createMolecule();
+  CPPUNIT_ASSERT(TestMolecule != NULL && "could not create molecule");
   for (double x=0.5;x<3;x+=1.)
     for (double y=0.5;y<3;y+=1.)
       for (double z=0.5;z<3;z+=1.) {
         Walker = World::getInstance().createAtom();
+        CPPUNIT_ASSERT(Walker != NULL && "could not create atom");
         Walker->type = hydrogen;
         *Walker->node = Vector(x, y, z );
@@ -67 +57 @@
   // construct linked cell
   LC = new LinkedCell (TestMolecule, 1.);
+  CPPUNIT_ASSERT(LC != NULL && "could not create LinkedCell");
 
   // check that TestMolecule was correctly constructed