Changeset f79d65 for tests/regression/Geometry/PositionToVector

Timestamp:

Jun 19, 2017, 8:24:16 AM (8 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.1, ChangeBugEmailaddress, ChemicalSpaceEvaluator, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, Fix_Verbose_Codepatterns, ForceAnnealing_oldresults, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps

Children:

1ba51c

Parents:

2eded3e

git-author:

Frederik Heber <heber@…> (03/30/17 21:59:00)

git-committer:

Frederik Heber <frederik.heber@…> (06/19/17 08:24:16)

Message:

Vector(s) are now stored as strings in Querys intermediately.

• they get evaluated first after being stored in a Parameter/Value on request via get().
• Needed to change all Vector(s)..Query's of all UIs and also the general base classes inside Dialog.
• QtQueryList need to be specialized in order to allow a QtQueryList<Vector> to actually store a vector of strings.
• we may use setAsString() in order to set the Parameter thankfully.
• TESTS: All regression tests on Geometry Actions are now working. Removed XFAIL from Options/Session test that use Python, i.e. the ones we marked four commits ago.

File:

• tests/regression/Geometry/PositionToVector/testsuite-geometry-position-to-vector.at (modified) (5 diffs)

tests/regression/Geometry/PositionToVector/testsuite-geometry-position-to-vector.at

@@ -20 +20 @@
 AT_SETUP([Geometry - position to vector])
 AT_KEYWORDS([geometry position-to-vector])
-AT_XFAIL_IF([/bin/true])
 file=test.xyz
 AT_CHECK([cp -f ${abs_top_srcdir}/tests/regression/Geometry/PositionToVector/pre/$file $file], 0, [ignore], [ignore])
@@ -26 +25 @@
 AT_CHECK([../../molecuilder -i $file -v 5 \
         --select-atom-by-id 0 --position-to-vector "testvector" --unselect-all-atoms \
-        --select-atom-by-element C --translate-atoms "testvector"], 0, [ignore], [ignore])
+        --select-atom-by-element C --translate-atoms --position "testvector"], 0, [ignore], [ignore])
 AT_CHECK([diff -I '.*reated.*' $file ${abs_top_srcdir}/tests/regression/Geometry/PositionToVector/post/$file], 0, [ignore], [ignore])
 AT_CLEANUP
@@ -32 +31 @@
 AT_SETUP([Geometry - position to vector Undo])
 AT_KEYWORDS([geometry position-to-vector undo])
-AT_XFAIL_IF([/bin/true])
 file=test.xyz
 AT_CHECK([cp -f ${abs_top_srcdir}/tests/regression/Geometry/PositionToVector/pre/$file $file], 0, [ignore], [ignore])
@@ -38 +36 @@
 AT_CHECK([../../molecuilder -i $file \
         --select-atom-by-id 0 --position-to-vector "testvector" --undo --unselect-all-atoms \
-        --select-atom-by-element C --translate-atoms "testvector"], 5, [ignore], [ignore])
+        --select-atom-by-element C --translate-atoms --position "testvector"], 5, [ignore], [ignore])
 AT_CLEANUP
 
 AT_SETUP([Geometry - position to vector Redo])
 AT_KEYWORDS([geometry position-to-vector undo redo])
-AT_XFAIL_IF([/bin/true])
 file=test.xyz
 AT_CHECK([cp -f ${abs_top_srcdir}/tests/regression/Geometry/PositionToVector/pre/$file $file], 0, [ignore], [ignore])
@@ -49 +46 @@
 AT_CHECK([../../molecuilder -i $file \
         --select-atom-by-id 0 --position-to-vector "testvector" --undo --redo --unselect-all-atoms \
-        --select-atom-by-element C --translate-atoms "testvector"], 0, [ignore], [ignore])
+        --select-atom-by-element C --translate-atoms --position "testvector"], 0, [ignore], [ignore])
 AT_CHECK([diff -I '.*reated.*' $file ${abs_top_srcdir}/tests/regression/Geometry/PositionToVector/post/$file], 0, [ignore], [ignore])
 AT_CLEANUP