Changeset e8c542 for src

Timestamp:

Nov 16, 2012, 11:10:56 AM (12 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

25e08a

Parents:

751d6b7

git-author:

Michael Ankele <ankele@…> (10/23/12 12:47:16)

git-committer:

Frederik Heber <heber@…> (11/16/12 11:10:56)

Message:

Refactoring: RandomNumberValidators as DiscreteValidator

Location:

src/Parameters/Validators/Specific

Files:

• RandomNumberValidators.cpp (modified) (4 diffs)
• RandomNumberValidators.hpp (modified) (2 diffs)

src/Parameters/Validators/Specific/RandomNumberValidators.cpp

@@ -41 +41 @@
 #include "RandomNumbers/RandomNumberEngineFactory.hpp"
 
+RandomNumberDistributionNameValidator::RandomNumberDistributionNameValidator() :
+  DiscreteValidator<std::string>(std::vector<std::string>())
+{}
+
 bool RandomNumberDistributionNameValidator::isValid(const std::string & _value) const
 {
@@ -52 +56 @@
   }
   return false;
+}
+
+const std::vector<std::string> &RandomNumberDistributionNameValidator::getValidValues() const
+{
+  currentList.clear();
+  RandomNumberDistributionFactory::getInstance();
+  for (RandomNumberDistributionFactory::NameMap::const_iterator
+      iter = RandomNumberDistributionFactory::getInstance().names.begin();
+      iter != RandomNumberDistributionFactory::getInstance().names.end();
+      ++iter)
+    currentList.push_back(iter->second);
+  return currentList;
 }
 
@@ -79 +95 @@
 
 
+RandomNumberEngineNameValidator::RandomNumberEngineNameValidator() :
+  DiscreteValidator<std::string>(std::vector<std::string>())
+{}
+
 bool RandomNumberEngineNameValidator::isValid(const std::string & _value) const
 {
@@ -90 +110 @@
   }
   return false;
+}
+
+const std::vector<std::string> &RandomNumberEngineNameValidator::getValidValues() const
+{
+  currentList.clear();
+  RandomNumberEngineFactory::getInstance();
+  for (RandomNumberEngineFactory::NameMap::const_iterator
+      iter = RandomNumberEngineFactory::getInstance().names.begin();
+      iter != RandomNumberEngineFactory::getInstance().names.end();
+      ++iter)
+    currentList.push_back(iter->second);
+  return currentList;
 }
 

src/Parameters/Validators/Specific/RandomNumberValidators.hpp

@@ -17 +17 @@
 #include <string>
 
-#include "Parameters/Validators/Validator.hpp"
+#include "Parameters/Validators/DiscreteValidator.hpp"
 
 /** This validator checks whether the given string contains the name of a
  * present \ref RandomNumberDistribution.
  */
-class RandomNumberDistributionNameValidator : public Validator<std::string>
+class RandomNumberDistributionNameValidator : public DiscreteValidator<std::string>
 {
+public:
+  RandomNumberDistributionNameValidator();
   bool isValid(const std::string & _value) const;
+  const std::vector<std::string> &getValidValues() const;
   bool operator==(const Validator<std::string> &_instance) const;
   Validator< std::string >* clone() const;
+private:
+  mutable std::vector<std::string> currentList;
 };
 
@@ -32 +37 @@
  * present \ref RandomNumberEngine.
  */
-class RandomNumberEngineNameValidator : public Validator<std::string>
+class RandomNumberEngineNameValidator : public DiscreteValidator<std::string>
 {
+public:
+  RandomNumberEngineNameValidator();
   bool isValid(const std::string & _value) const;
+  const std::vector<std::string> &getValidValues() const;
   bool operator==(const Validator<std::string> &_instance) const;
   Validator< std::string >* clone() const;
+private:
+  mutable std::vector<std::string> currentList;
 };