Changeset e6fdbe

Timestamp:

Feb 26, 2010, 10:02:12 AM (15 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

706f9b, a1510d

Parents:

5e5283

Message:

MEMLEAK: In many tests World, MemoryUsageObserver, logger or errorLogger being singletons were instantiated but not destroyed.

• in some cases respective includes had to be added.

Location:

src/unittests

Files:

• AnalysisCorrelationToPointUnitTest.cpp (modified) (2 diffs)
• AnalysisCorrelationToSurfaceUnitTest.cpp (modified) (2 diffs)
• AnalysisPairCorrelationUnitTest.cpp (modified) (2 diffs)
• bondgraphunittest.cpp (modified) (2 diffs)
• infounittest.cpp (modified) (2 diffs)
• listofbondsunittest.cpp (modified) (2 diffs)
• logunittest.cpp (modified) (1 diff)
• memoryallocatorunittest.cpp (modified) (2 diffs)
• stackclassunittest.cpp (modified) (1 diff)
• vectorunittest.cpp (modified) (2 diffs)

src/unittests/AnalysisCorrelationToPointUnitTest.cpp

@@ -24 +24 @@
 #include "periodentafel.hpp"
 #include "tesselation.hpp"
+#include "World.hpp"
 
 #ifdef HAVE_TESTRUNNER
@@ -107 +108 @@
   delete(tafel);
   // note that element is cleaned by periodentafel
+  World::destroy();
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
 };
 

src/unittests/AnalysisCorrelationToSurfaceUnitTest.cpp

@@ -24 +24 @@
 #include "periodentafel.hpp"
 #include "tesselation.hpp"
+#include "World.hpp"
 
 #ifdef HAVE_TESTRUNNER
@@ -137 +138 @@
   delete(tafel);
   // note that element is cleaned by periodentafel
+  World::destroy();
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
 };
 

src/unittests/AnalysisPairCorrelationUnitTest.cpp

@@ -24 +24 @@
 #include "periodentafel.hpp"
 #include "tesselation.hpp"
+#include "World.hpp"
 
 #ifdef HAVE_TESTRUNNER
@@ -102 +103 @@
   delete(tafel);
   // note that element is cleaned by periodentafel
+  World::destroy();
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
+  errorLogger::purgeInstance();
 };
 

src/unittests/bondgraphunittest.cpp

@@ -23 +23 @@
 #include "periodentafel.hpp"
 #include "bondgraphunittest.hpp"
+#include "World.hpp"
 
 #ifdef HAVE_TESTRUNNER
@@ -104 +105 @@
   delete(tafel);
   // note that element is cleaned by periodentafel
+  World::destroy();
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
 };
 

src/unittests/infounittest.cpp

@@ -17 +17 @@
 #include "info.hpp"
 #include "infounittest.hpp"
+#include "log.hpp"
 
 #ifdef HAVE_TESTRUNNER
@@ -35 +36 @@
 void InfoTest::tearDown()
 {
+  logger::purgeInstance();
 };
 

src/unittests/listofbondsunittest.cpp

@@ -21 +21 @@
 #include "molecule.hpp"
 #include "periodentafel.hpp"
+#include "World.hpp"
 
 #ifdef HAVE_TESTRUNNER
@@ -84 +85 @@
   delete(tafel);
   // note that element is cleaned by periodentafel
+  World::destroy();
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
 };
 

src/unittests/logunittest.cpp

@@ -31 +31 @@
 void LogTest::tearDown()
 {
+  logger::purgeInstance();
+  errorLogger::purgeInstance();
 };
 

src/unittests/memoryallocatorunittest.cpp

@@ -13 +13 @@
 #include "memoryallocatorunittest.hpp"
 #include "helpers.hpp"
+#include "log.hpp"
 #include "defs.hpp"
 
@@ -33 +34 @@
 {
   MemoryUsageObserver::getInstance()->purgeInstance();
+  logger::purgeInstance();
 };
 

src/unittests/stackclassunittest.cpp

@@ -37 +37 @@
   Stack->ClearStack();
   delete(Stack);
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
 };
 

src/unittests/vectorunittest.cpp

@@ -14 +14 @@
 
 #include "defs.hpp"
+#include "log.hpp"
+#include "memoryusageobserver.hpp"
 #include "vector.hpp"
 #include "vectorunittest.hpp"
@@ -39 +41 @@
 void VectorTest::tearDown()
 {
+  MemoryUsageObserver::purgeInstance();
+  logger::purgeInstance();
+  errorLogger::purgeInstance();
 };