Changeset c8cb0d for src/Actions

Timestamp:

Dec 26, 2025, 9:40:14 PM (6 weeks ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.1, stable

Children:

033646

Parents:

f2d5ce

git-author:

Frederik Heber <frederik.heber@…> (12/10/25 16:15:28)

git-committer:

Frederik Heber <frederik.heber@…> (12/26/25 21:40:14)

Message:

Streamlines channel creation in Observables.

• CodePatterns is now version 1.3.4.
• we no longer need to add the channels manually in the cstor of a class that derives from Observable. Instead, we just need to pass the maximum number of channels (as they are typically enumerated anyway) and they are generated and added.
• added mutex protection when inserting.
• adjusted class Relay to forward similar convenience cstors.
• adjusted all call sites in molecuilder.

Location:

src/Actions

Files:

• ActionQueue.cpp (modified) (2 diffs)
• ActionStatusList.cpp (modified) (1 diff)

src/Actions/ActionQueue.cpp

@@ -62 +62 @@
 
 ActionQueue::ActionQueue() :
-    Observable("ActionQueue"),
+    Observable("ActionQueue", NotificationType_MAX),
     AR(new ActionRegistry()),
     history(new ActionHistory),
@@ -72 +72 @@
 #endif
     dryrun_flag(false)
-{
-  // channels of observable
-  Channels *OurChannel = new Channels;
-  Observable::insertNotificationChannel( std::make_pair(static_cast<Observable *>(this), OurChannel) );
-  // add instance for each notification type
-  for (size_t type = 0; type < NotificationType_MAX; ++type)
-    OurChannel->addChannel(type);
-}
+{}
 
 ActionQueue::~ActionQueue()

src/Actions/ActionStatusList.cpp

@@ -42 +42 @@
 
 ActionStatusList::ActionStatusList() :
-  Observable("ActionStatusList")
-{
-  Channels *OurChannel = new Channels;
-  Observable::insertNotificationChannel( std::make_pair(static_cast<Observable *>(this), OurChannel) );
-  // add instance for each notification type
-  for (size_t type = 0; type < NotificationType_MAX; ++type)
-    OurChannel->addChannel(type);
-}
+  Observable("ActionStatusList", NotificationType_MAX)
+{}
 
 ActionStatusList::~ActionStatusList()