Changeset be21fa for src/Actions/SelectionAction/Molecules

Timestamp:

Apr 11, 2012, 4:53:04 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

b2c302

Parents:

3e93332

git-author:

Frederik Heber <heber@…> (04/11/12 16:18:23)

git-committer:

Frederik Heber <heber@…> (04/11/12 16:53:04)

Message:

Moved getParametersfromValueStorage() call from each single Action into base class Action::call().

Location:

src/Actions/SelectionAction/Molecules

Files:

• AllMoleculesAction.cpp (modified) (1 diff)
• ClearAllMoleculesAction.cpp (modified) (1 diff)
• InvertMoleculesAction.cpp (modified) (1 diff)
• MoleculeByFormulaAction.cpp (modified) (1 diff)
• MoleculeByIdAction.cpp (modified) (1 diff)
• MoleculeByNameAction.cpp (modified) (1 diff)
• MoleculeByOrderAction.cpp (modified) (1 diff)
• MoleculeOfAtomAction.cpp (modified) (1 diff)
• NotAllMoleculesAction.cpp (modified) (1 diff)
• NotMoleculeByFormulaAction.cpp (modified) (1 diff)
• NotMoleculeByIdAction.cpp (modified) (1 diff)
• NotMoleculeByNameAction.cpp (modified) (1 diff)
• NotMoleculeByOrderAction.cpp (modified) (1 diff)
• NotMoleculeOfAtomAction.cpp (modified) (1 diff)

src/Actions/SelectionAction/Molecules/AllMoleculesAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAllMoleculesAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<molecule *> selectedMolecules = World::getInstance().getSelectedMolecules();
   LOG(1, "Selecting all molecules.");

src/Actions/SelectionAction/Molecules/ClearAllMoleculesAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionClearAllMoleculesAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<molecule *> selectedMolecules = World::getInstance().getSelectedMolecules();
   LOG(1, "Clearing molecule selection.");

src/Actions/SelectionAction/Molecules/InvertMoleculesAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionInvertMoleculesAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   World::getInstance().invertMoleculeSelection();
   LOG(0, World::getInstance().countSelectedMolecules() << " molecules selected.");

src/Actions/SelectionAction/Molecules/MoleculeByFormulaAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionMoleculeByFormulaAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Selecting molecules with chemical formula " << params.formula << ":");
 //  std::vector<molecule *> matchingMolecules = World::getInstance().getAllMolecules(MoleculeByFormula(params.formula));

src/Actions/SelectionAction/Molecules/MoleculeByIdAction.cpp

@@ -38 +38 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionMoleculeByIdAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   const molecule *mol = World::getInstance().getMolecule(MoleculeById(params.molindex));
   if (mol != NULL) {

src/Actions/SelectionAction/Molecules/MoleculeByNameAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionMoleculeByNameAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Selecting all molecules called " << params.molname);
   std::vector<molecule *> selectedMolecules =

src/Actions/SelectionAction/Molecules/MoleculeByOrderAction.cpp

@@ -39 +39 @@
 
 Action::state_ptr SelectionMoleculeByOrderAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   molecule *mol = World::getInstance().getMolecule(MoleculeByOrder(params.molindex));
 

src/Actions/SelectionAction/Molecules/MoleculeOfAtomAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionMoleculeOfAtomAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<molecule *> selectedMolecules = World::getInstance().getSelectedMolecules();
   LOG(1, "Selecting molecule to currently selected atoms.");

src/Actions/SelectionAction/Molecules/NotAllMoleculesAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAllMoleculesAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<molecule *> selectedMolecules = World::getInstance().getSelectedMolecules();
   LOG(1, "Unselecting all molecules.");

src/Actions/SelectionAction/Molecules/NotMoleculeByFormulaAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotMoleculeByFormulaAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Unselecting molecules with chemical formula " << params.formula << ":");
   std::vector<molecule *> matchingMolecules = World::getInstance().getAllMolecules(MoleculeByFormula(params.formula));

src/Actions/SelectionAction/Molecules/NotMoleculeByIdAction.cpp

@@ -38 +38 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotMoleculeByIdAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   const molecule *mol = World::getInstance().getMolecule(MoleculeById(params.molindex));
   if (mol != NULL) {

src/Actions/SelectionAction/Molecules/NotMoleculeByNameAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotMoleculeByNameAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Unselecting all molecule called " << params.molname);
   std::vector<molecule *> unselectedMolecules =

src/Actions/SelectionAction/Molecules/NotMoleculeByOrderAction.cpp

@@ -39 +39 @@
 
 Action::state_ptr SelectionNotMoleculeByOrderAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   molecule *mol = World::getInstance().getMolecule(MoleculeByOrder(params.molindex));
 

src/Actions/SelectionAction/Molecules/NotMoleculeOfAtomAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotMoleculeOfAtomAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<molecule *> unselectedMolecules = World::getInstance().getSelectedMolecules();
   LOG(1, "Unselecting molecule to currently selected atoms.");