Changeset be21fa for src/Actions/SelectionAction/Atoms

Timestamp:

Apr 11, 2012, 4:53:04 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

b2c302

Parents:

3e93332

git-author:

Frederik Heber <heber@…> (04/11/12 16:18:23)

git-committer:

Frederik Heber <heber@…> (04/11/12 16:53:04)

Message:

Moved getParametersfromValueStorage() call from each single Action into base class Action::call().

Location:

src/Actions/SelectionAction/Atoms

Files:

• AllAtomsAction.cpp (modified) (1 diff)
• AllAtomsInsideCuboidAction.cpp (modified) (1 diff)
• AllAtomsInsideSphereAction.cpp (modified) (1 diff)
• AllAtomsOfMoleculeAction.cpp (modified) (1 diff)
• AtomByElementAction.cpp (modified) (1 diff)
• AtomByIdAction.cpp (modified) (1 diff)
• AtomByOrderAction.cpp (modified) (1 diff)
• ClearAllAtomsAction.cpp (modified) (1 diff)
• InvertAtomsAction.cpp (modified) (1 diff)
• NotAllAtomsAction.cpp (modified) (1 diff)
• NotAllAtomsInsideCuboidAction.cpp (modified) (1 diff)
• NotAllAtomsInsideSphereAction.cpp (modified) (1 diff)
• NotAllAtomsOfMoleculeAction.cpp (modified) (1 diff)
• NotAtomByElementAction.cpp (modified) (1 diff)
• NotAtomByIdAction.cpp (modified) (1 diff)
• NotAtomByOrderAction.cpp (modified) (1 diff)

src/Actions/SelectionAction/Atoms/AllAtomsAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAllAtomsAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<atom *> selectedAtoms = World::getInstance().getSelectedAtoms();
   LOG(1, "Selecting all atoms.");

src/Actions/SelectionAction/Atoms/AllAtomsInsideCuboidAction.cpp

@@ -47 +47 @@
   RealSpaceMatrix RotationMatrix;
 
-  // obtain information
-  getParametersfromValueStorage();
-
   RotationMatrix.setRotation(params.Xangle, params.Yangle, params.Zangle);
 

src/Actions/SelectionAction/Atoms/AllAtomsInsideSphereAction.cpp

@@ -44 +44 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAllAtomsInsideSphereAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Selecting all atoms inside a sphere at " << params.position << " with radius " << params.radius << ".");
   Shape s = translate(resize(Sphere(),params.radius),params.position);

src/Actions/SelectionAction/Atoms/AllAtomsOfMoleculeAction.cpp

@@ -41 +41 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAllAtomsOfMoleculeAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Selecting all atoms of currently selected molecule.");
   std::vector<atom *> selectedAtoms = World::getInstance().getAllAtoms(AtomsBySelection());

src/Actions/SelectionAction/Atoms/AtomByElementAction.cpp

@@ -41 +41 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAtomByElementAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Selecting atoms of type " << *params.elemental);
   std::vector<atom *> selectedAtoms = World::getInstance().getAllAtoms(AtomsBySelection());

src/Actions/SelectionAction/Atoms/AtomByIdAction.cpp

@@ -38 +38 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAtomByIdAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   const atom *Walker = World::getInstance().getAtom(AtomById(params.WalkerId));
   if (Walker != NULL) {

src/Actions/SelectionAction/Atoms/AtomByOrderAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionAtomByOrderAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   const atom *Walker = World::getInstance().getAtom(AtomByOrder(params.order));
   if (Walker != NULL) {

src/Actions/SelectionAction/Atoms/ClearAllAtomsAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionClearAllAtomsAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<atom *> selectedAtoms = World::getInstance().getSelectedAtoms();
   LOG(1, "Clearing atoms selection.");

src/Actions/SelectionAction/Atoms/InvertAtomsAction.cpp

@@ -40 +40 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionInvertAtomsAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Inverting atom selection.");
 

src/Actions/SelectionAction/Atoms/NotAllAtomsAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAllAtomsAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   std::vector<atom *> selectedAtoms = World::getInstance().getSelectedAtoms();
   LOG(1, "Unselecting all atoms.");

src/Actions/SelectionAction/Atoms/NotAllAtomsInsideCuboidAction.cpp

@@ -46 +46 @@
 Action::state_ptr SelectionNotAllAtomsInsideCuboidAction::performCall() {
   RealSpaceMatrix RotationMatrix;
-
-  // obtain information
-  getParametersfromValueStorage();
   RotationMatrix.setRotation(params.Xangle, params.Yangle, params.Zangle);
 

src/Actions/SelectionAction/Atoms/NotAllAtomsInsideSphereAction.cpp

@@ -44 +44 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAllAtomsInsideSphereAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Unselecting all atoms inside a sphere at " << params.position << " with radius " << params.radius << ".");
   Shape s = translate(resize(Sphere(),params.radius),params.position);

src/Actions/SelectionAction/Atoms/NotAllAtomsOfMoleculeAction.cpp

@@ -41 +41 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAllAtomsOfMoleculeAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Unselecting all atoms of currently selected molecules.");
   std::vector<atom *> unselectedAtoms = World::getInstance().getAllAtoms(!AtomsBySelection());

src/Actions/SelectionAction/Atoms/NotAtomByElementAction.cpp

@@ -41 +41 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAtomByElementAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   LOG(1, "Unselecting atoms of type " << *params.elemental);
   std::vector<atom *> unselectedAtoms = World::getInstance().getAllAtoms(!AtomsBySelection());

src/Actions/SelectionAction/Atoms/NotAtomByIdAction.cpp

@@ -38 +38 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAtomByIdAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   const atom * Walker = World::getInstance().getAtom(AtomById(params.WalkerId));
   if (Walker != NULL) {

src/Actions/SelectionAction/Atoms/NotAtomByOrderAction.cpp

@@ -39 +39 @@
 /** =========== define the function ====================== */
 Action::state_ptr SelectionNotAtomByOrderAction::performCall() {
-  // obtain information
-  getParametersfromValueStorage();
-
   const atom * Walker = World::getInstance().getAtom(AtomByOrder(params.order));
   if (Walker != NULL) {