Changeset a6ceab for src

Timestamp:

Sep 19, 2013, 8:23:52 PM (11 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

0c8056

Parents:

690741

git-author:

Frederik Heber <heber@…> (08/16/13 12:55:52)

git-committer:

Frederik Heber <heber@…> (09/19/13 20:23:52)

Message:

FIX: ActionRegistry's function now get ref to token string.

Location:

src/Actions

Files:

• ActionQueue.cpp (modified) (2 diffs)
• ActionQueue.hpp (modified) (3 diffs)
• ActionRegistry.cpp (modified) (2 diffs)
• ActionRegistry.hpp (modified) (1 diff)

src/Actions/ActionQueue.cpp

@@ -51 +51 @@
 {}
 
-Action* ActionQueue::getActionByName(const std::string name)
+Action* ActionQueue::getActionByName(const std::string &name)
 {
   return AR.getActionByName(name);
 }
 
-bool ActionQueue::isActionKnownByName(const std::string name) const
+bool ActionQueue::isActionKnownByName(const std::string &name) const
 {
   return AR.isActionPresentByName(name);
@@ -66 +66 @@
 }
 
-const ActionTrait& ActionQueue::getActionsTrait(const std::string name) const
+const ActionTrait& ActionQueue::getActionsTrait(const std::string &name) const
 {
   // this const_cast is just required as long as we have a non-const getActionByName

src/Actions/ActionQueue.hpp

@@ -43 +43 @@
    * \return pointer to newly spawned action
    */
-  Action* getActionByName(const std::string name);
+  Action* getActionByName(const std::string &name);
 
   /** Checks whether the Action is known by the given \a name.
@@ -50 +50 @@
    * \return true - token is known, false - else
    */
-  bool isActionKnownByName(const std::string name) const;
+  bool isActionKnownByName(const std::string &name) const;
 
   /** Returns the last taken position for the Menu with \a MenuName.
@@ -70 +70 @@
    * \return const ref to its default Trait.
    */
-  const ActionTrait& getActionsTrait(const std::string name) const;
+  const ActionTrait& getActionsTrait(const std::string &name) const;
 
   /** Getter function for the ActionRegistry for transitional purpose.

src/Actions/ActionRegistry.cpp

@@ -130 +130 @@
  * \return pointer to Action
  */
-Action* ActionRegistry::getActionByName(const std::string name)
+Action* ActionRegistry::getActionByName(const std::string &name)
 {
   return getByName(name);
@@ -139 +139 @@
  * \return true - Action instance present, false - not
  */
-bool ActionRegistry::isActionPresentByName(const std::string name) const
+bool ActionRegistry::isActionPresentByName(const std::string &name) const
 {
   return isPresentByName(name);

src/Actions/ActionRegistry.hpp

@@ -42 +42 @@
 
 public:
-  Action* getActionByName(const std::string name);
-  bool isActionPresentByName(const std::string name) const;
+  Action* getActionByName(const std::string &name);
+  bool isActionPresentByName(const std::string &name) const;
   int getLastPosition(const std::string &MenuName) const;