Changeset a2a2f7 for src/Fragmentation


Ignore:
Timestamp:
Apr 29, 2014, 12:42:43 PM (11 years ago)
Author:
Frederik Heber <heber@…>
Branches:
Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable
Children:
ae68b5
Parents:
c9db50
git-author:
Frederik Heber <heber@…> (02/01/14 15:42:09)
git-committer:
Frederik Heber <heber@…> (04/29/14 12:42:43)
Message:

Huge warning fix.

  • fixed unused variables.
  • fixed set but unused variables.
  • fixed signed vs. unsigned int comparison.
  • fixed static_warning_test<false, 98> (commented out _IMPLEMENT).
Location:
src/Fragmentation
Files:
15 edited

Legend:

Unmodified
Added
Removed
  • src/Fragmentation/AdaptivityMap.cpp

    rc9db50 ra2a2f7  
    205205      runner != enditer; ++runner) {
    206206    const int No = (*runner).second.first;
    207     const atom *Walker = mol->FindAtom(No);
     207//    const atom *Walker = mol->FindAtom(No);
    208208    LOG(2, "Root " << No << " is already below threshold (10^{" << Order <<"}: " << runner->first << ", setting entry " << No << " of Atom mask to false.");
    209209    AtomMask.setFalse(No);
  • src/Fragmentation/BondsPerShortestPath.cpp

    rc9db50 ra2a2f7  
    133133  // In another picture, the bonds always contain a direction by rightatom being the one more distant from root and hence
    134134  // naturally leftatom forming its predecessor, preventing the BFS"seeker" from continuing in the wrong direction.
    135   int AtomKeyNr = -1;
     135//  int AtomKeyNr = -1;
    136136  atom *Walker = NULL;
    137137  atom *OtherWalker = NULL;
     
    162162      Walker = (*CurrentEdge)->rightatom;    // rightatom is always the one more distant
    163163      Predecessor = (*CurrentEdge)->leftatom;    // ... and leftatom is predecessor
    164       AtomKeyNr = Walker->getNr();
     164//      AtomKeyNr = Walker->getNr();
    165165      LOG(1, "INFO: Current Walker is: " << *Walker << " with nr " << Walker->getNr() << " and SP of " << SP << ", with " << RemainingWalkers << " remaining walkers on this level.");
    166166      // check for new sp level
  • src/Fragmentation/Exporters/ExportGraph.cpp

    rc9db50 ra2a2f7  
    6060  const enum HydrogenSaturation _saturation) :
    6161  TotalGraph(_graph),
    62   CurrentKeySet(TotalGraph.begin()),
    6362  BondFragments(World::getPointer()),
    6463  treatment(_treatment),
    65   saturation(_saturation)
     64  saturation(_saturation),
     65  CurrentKeySet(TotalGraph.begin())
    6666{
    6767}
  • src/Fragmentation/Fragmentation.cpp

    rc9db50 ra2a2f7  
    235235  Info FunctionInfo(__func__);
    236236  std::vector<Graph*> *FragmentLowerOrdersList = NULL;
    237   int NumLevels = 0;
    238   int NumMolecules = 0;
    239   int TotalNumMolecules = 0;
     237  size_t NumLevels = 0;
     238//  size_t NumMolecules = 0;
     239  size_t TotalNumMolecules = 0;
    240240  int *NumMoleculesOfOrder = NULL;
    241241  int Order = 0;
     
    296296      // output resulting number
    297297      LOG(1, "INFO: Number of resulting KeySets is: " << NumMoleculesOfOrder[RootNr] << ".");
    298       if (NumMoleculesOfOrder[RootNr] != 0) {
    299         NumMolecules = 0;
    300       }
     298//      if (NumMoleculesOfOrder[RootNr] != 0) {
     299//        NumMolecules = 0;
     300//      }
    301301      // now, we have completely filled each cell of FragmentLowerOrdersList[] for the current Walker->AdaptiveOrder
    302302      //NumMoleculesOfOrder[Walker->AdaptiveOrder-1] = NumMolecules;
     
    441441  }
    442442  LOG(1, output.str());
     443  return true;
    443444};
    444445
  • src/Fragmentation/Homology/FragmentEdge.cpp

    rc9db50 ra2a2f7  
    124124}
    125125
    126 
    127 // we need to explicitly instantiate the serialization functions
    128 BOOST_CLASS_EXPORT_IMPLEMENT(FragmentEdge)
     126//
     127//// we need to explicitly instantiate the serialization functions
     128//BOOST_CLASS_EXPORT_IMPLEMENT(FragmentEdge)
  • src/Fragmentation/Homology/FragmentNode.cpp

    rc9db50 ra2a2f7  
    108108}
    109109
    110 
    111 // we need to explicitly instantiate the serialization functions
    112 BOOST_CLASS_EXPORT_IMPLEMENT(FragmentNode)
     110//
     111//// we need to explicitly instantiate the serialization functions
     112//BOOST_CLASS_EXPORT_IMPLEMENT(FragmentNode)
  • src/Fragmentation/Homology/HomologyContainer.hpp

    rc9db50 ra2a2f7  
    1919#include <boost/serialization/split_member.hpp>
    2020#include <boost/serialization/vector.hpp>
     21#include <boost/serialization/version.hpp>
    2122
    2223#include <iosfwd>
  • src/Fragmentation/Homology/HomologyGraph.cpp

    rc9db50 ra2a2f7  
    153153}
    154154
    155 // we need to explicitly instantiate the serialization functions
    156 BOOST_CLASS_EXPORT_IMPLEMENT(HomologyGraph)
    157 
     155//
     156//// we need to explicitly instantiate the serialization functions
     157//BOOST_CLASS_EXPORT_IMPLEMENT(HomologyGraph)
  • src/Fragmentation/Homology/unittests/stubs/FragmentStub.cpp

    rc9db50 ra2a2f7  
    126126//  static bool Fragment::isPositionEqual(const position_t &a, const position_t &b);
    127127
    128 // we need to explicitly instantiate the serialization functions
    129 BOOST_CLASS_EXPORT_IMPLEMENT(Fragment)
     128//
     129//// we need to explicitly instantiate the serialization functions
     130//BOOST_CLASS_EXPORT_IMPLEMENT(Fragment)
    130131
    131132/** Equality operator for two nuclei.
  • src/Fragmentation/Summation/Containers/FragmentationResultContainer.hpp

    rc9db50 ra2a2f7  
    1515
    1616#include <boost/serialization/access.hpp>
     17#include <boost/serialization/map.hpp>
     18#include <boost/serialization/split_member.hpp>
     19#include <boost/serialization/version.hpp>
    1720#include "CodePatterns/Singleton.hpp"
    1821
     
    167170  // serialization
    168171  template <typename Archive>
    169   void serialize(Archive& ar, const unsigned int version)
     172  void load(Archive& ar, const unsigned int version)
     173  {
     174    OBSERVE;
     175    ar & ResultsType;
     176    ar & keysets;
     177    ar & forcekeysets;
     178    ar & shortrangedata;
     179    if (version > 0)
     180      ar & cycles;
     181    if (version > 1)
     182      ar & summedshortrange;
     183#ifdef HAVE_VMG
     184    ar & longrangedata;
     185#endif
     186  }
     187  template <typename Archive>
     188  void save(Archive& ar, const unsigned int version) const
    170189  {
    171190    ar & ResultsType;
     
    181200#endif
    182201  }
     202  BOOST_SERIALIZATION_SPLIT_MEMBER()
    183203};
    184204
  • src/Fragmentation/Summation/Containers/MPQCData.hpp

    rc9db50 ra2a2f7  
    1616#include <boost/serialization/access.hpp>
    1717#include <boost/serialization/vector.hpp>
     18#include <boost/serialization/version.hpp>
    1819
    1920#include <iosfwd>
  • src/Fragmentation/Summation/IndexSetContainer.cpp

    rc9db50 ra2a2f7  
    7070    for(IndexSet::const_iterator keyiter = (*iter).begin();
    7171        keyiter != (*iter).end(); ++keyiter) {
    72       if (*keyiter != -1)
     72      if (*keyiter != (size_t)-1)
    7373        _AllIndices->insert((Index_t)*keyiter);
    7474    }
     
    8686    for(IndexSet::const_iterator keyiter = (*iter)->begin();
    8787        keyiter != (*iter)->end(); ++keyiter) {
    88       if (*keyiter != -1)
     88      if (*keyiter != (size_t)-1)
    8989        _AllIndices->insert((Index_t)*keyiter);
    9090    }
  • src/Fragmentation/Summation/SetValues/Fragment.cpp

    rc9db50 ra2a2f7  
    195195}
    196196
    197 
    198 // we need to explicitly instantiate the serialization functions
    199 BOOST_CLASS_EXPORT_IMPLEMENT(Fragment)
     197// below is not needed as we have above static ZeroInstace instantiating the code
     198
     199//// we need to explicitly instantiate the serialization functions
     200//BOOST_CLASS_EXPORT_IMPLEMENT(Fragment)
  • src/Fragmentation/Summation/SetValues/unittests/EigenvaluesUnitTest.cpp

    rc9db50 ra2a2f7  
    170170    const size_t othersubtractedsize = otherev.subtractedsamples.size();
    171171    const size_t addedsize = ev->addedsamples.size();
    172     const size_t subtractedsize = ev->subtractedsamples.size();
     172//    const size_t subtractedsize = ev->subtractedsamples.size();
    173173    *ev -= otherev;
    174174    // otherev did not change
     
    193193    const size_t othersubtractedsize = otherev.subtractedsamples.size();
    194194    const size_t addedsize = ev->addedsamples.size();
    195     const size_t subtractedsize = ev->subtractedsamples.size();
     195//    const size_t subtractedsize = ev->subtractedsamples.size();
    196196    *ev -= otherev;
    197197    // otherev did not change
  • src/Fragmentation/fragmentation_helpers.cpp

    rc9db50 ra2a2f7  
    9292  int StartNr = 0;
    9393  int counter = 0;
    94   int NumLevels = 0;
     94  size_t NumLevels = 0;
    9595  atom *Walker = NULL;
    9696
     
    106106    ASSERT( NumLevels == FragmentLowerOrdersList[RootNr].size(),
    107107        "CombineAllOrderListIntoOne() - differing size and NumLevels.");
    108     for(int i=0;i<NumLevels;i++) {
     108    for(size_t i=0;i<NumLevels;i++) {
    109109      if (FragmentLowerOrdersList[RootNr][i] != NULL) {
    110110        FragmentList.InsertGraph((*FragmentLowerOrdersList[RootNr][i]), counter);
Note: See TracChangeset for help on using the changeset viewer.