Changeset 9e7089

Timestamp:

May 25, 2016, 7:13:57 AM (9 years ago)

Author:

Frederik Heber <heber@…>

Children:

9cbbe1

Parents:

996ef1

git-author:

Frederik Heber <heber@…> (05/10/16 09:01:26)

git-committer:

Frederik Heber <heber@…> (05/25/16 07:13:57)

Message:

FIX: In debug we asserted possible deleteNode() in LinkedCell_model.

• but this is wrong because deleteNode overrides addNode. If the update was not yet processed, the node was not added and hence cannot be found. This is also the desired behavior such that no real work is done if some node has been added and deleted in between two reads, e.h. saturation hydrogens.

File:

• src/LinkedCell/LinkedCell_Model.cpp (modified) (1 diff)

src/LinkedCell/LinkedCell_Model.cpp

@@ -382 +382 @@
 {
   MapPointToCell::iterator iter = CellLookup.find(Walker);
-  ASSERT(iter != CellLookup.end(),
-      "LinkedCell_Model::deleteNode() - Walker not present in cell stored under CellLookup.");
+  // must not ASSERT presence as addNode might have been overrided by this
+  // deleteNode update and hence the node will not be present
   if (iter != CellLookup.end()) {
     // remove from lookup