Changeset 9dcce3

Timestamp:

Jul 6, 2012, 10:18:43 AM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

685e28

Parents:

311137

git-author:

Frederik Heber <heber@…> (05/31/12 08:33:43)

git-committer:

Frederik Heber <heber@…> (07/06/12 10:18:43)

Message:

Refactored parsing of command line parameters into structure ControllerOptions.

• this structure can be derived from to add other parsing functions and options.

File:

• src/controller.cpp (modified) (9 diffs)

src/controller.cpp

@@ -306 +306 @@
 }
 
+struct ControllerOptions
+{
+  int parseHelp(boost::program_options::variables_map &vm, const boost::program_options::options_description &desc) {
+    if (vm.count("help")) {
+      std::cout << desc << "\n";
+      return 1;
+    }
+    return 0;
+  }
+  int parseVerbosity(boost::program_options::variables_map &vm) {
+    if (vm.count("verbosity")) {
+      LOG(0, "STATUS: Verbosity level was set to " << vm["verbosity"].as<size_t>() << ".");
+      setVerbosity(vm["verbosity"].as<size_t>());
+    } else {
+      LOG(0, "STATUS: Verbosity level was not set, defaulting to 5.");
+      setVerbosity(5);
+    }
+    return 0;
+  }
+
+  int parseServerPort(boost::program_options::variables_map &vm) {
+    if (vm.count("server")) {
+      server = vm["server"].as< std::string >();
+      serverport = server.substr(server.find_last_of(':')+1, std::string::npos);
+      server = server.substr(0, server.find_last_of(':'));
+      try {
+        boost::lexical_cast<size_t>(serverport);
+      } catch (boost::bad_lexical_cast &) {
+        ELOG(1, "Could not interpret " << serverport << " as server:port.");
+        return 255;
+      }
+      LOG(1, "INFO: Using " << server << ":" << serverport << " as server's address.");
+    } else {
+      ELOG(1, "Requiring server's address (host:port) to connect to.");
+      return 255;
+    }
+    return 0;
+  }
+
+  int parseCommand(boost::program_options::variables_map &vm, const std::vector<std::string> &Commands) {
+    if (!vm.count("command")) {
+      ELOG(1, "Controller requires one of the following commands: "+toString(Commands));
+      return 255;
+    }
+    command = vm["command"].as< std::string >();
+    return 0;
+  }
+
+  std::string command;
+  std::string server;
+  std::string serverport;
+
+};
+
+struct ControllerOptions_SystemCommandJob : public ControllerOptions
+{
+  int parseExecutable(boost::program_options::variables_map &vm) {
+    if ((command == "createjobs") || (command == "addjobs")) {
+      if (!vm.count("executable")) {
+        ELOG(1, "'"+command+"' requires two options: [executable] [jobcommand].");
+        return 255;
+      }
+      executable = vm["executable"].as< std::string >();
+    }
+    return 0;
+  }
+
+  int parseJobCommand(boost::program_options::variables_map &vm) {
+    if (command == "createjobs") {
+      if (!vm.count("jobcommand")) {
+        ELOG(1, "'"+command+"' requires two options: [executable] [jobcommand].");
+        return 255;
+      }
+      jobcommand = vm["jobcommand"].as< std::string >();
+    }
+    return 0;
+  }
+
+  std::string executable;
+  std::string jobcommand;
+};
 
 int main(int argc, char* argv[])
@@ -345 +426 @@
   boost::program_options::store(boost::program_options::parse_command_line(argc, argv, desc), vm);
   boost::program_options::notify(vm);
-
-  if (vm.count("help")) {
-    std::cout << desc << "\n";
-    return 1;
-  }
-
-  if (vm.count("verbosity")) {
-    LOG(0, "STATUS: Verbosity level was set to " << vm["verbosity"].as<size_t>() << ".");
-    setVerbosity(vm["verbosity"].as<size_t>());
-  } else {
-    LOG(0, "STATUS: Verbosity level was not set, defaulting to 5.");
-    setVerbosity(5);
-  }
-
-  std::string server;
-  std::string serverport;
-  if (vm.count("server")) {
-    server = vm["server"].as< std::string >();
-    serverport = server.substr(server.find_last_of(':')+1, std::string::npos);
-    server = server.substr(0, server.find_last_of(':'));
-    try {
-      boost::lexical_cast<size_t>(serverport);
-    } catch (boost::bad_lexical_cast) {
-      ELOG(1, "Could not interpret " << serverport << " as server:port.");
-      return 255;
-    }
-    LOG(1, "INFO: Using " << server << ":" << serverport << " as server's address.");
-  } else {
-    ELOG(1, "Requiring server's address (host:port) to connect to.");
-    return 255;
-  }
-
-  if (!vm.count("command")) {
-    ELOG(1, "Controller requires one of the following commands: "+toString(Commands));
-    return 255;
-  }
-  const std::string command = vm["command"].as< std::string >();
-  const CommandIndices commandIndex = getCommandIndex(CommandsMap, command);
+  ControllerOptions_SystemCommandJob ControllerInfo;
+
+  ControllerInfo.parseHelp(vm, desc);
+
+  ControllerInfo.parseVerbosity(vm);
+
+  ControllerInfo.parseServerPort(vm);
+
+  ControllerInfo.parseCommand(vm, Commands);
+  const CommandIndices commandIndex = getCommandIndex(CommandsMap, ControllerInfo.command);
+
+  ControllerInfo.parseExecutable(vm);
+
+  ControllerInfo.parseJobCommand(vm);
 
   // check arguments
   switch(commandIndex) {
     case AddJobsIndex:
-      if (!vm.count("executable") && !vm.count("jobfiles")) {
-        ELOG(1, "'"+command+"' requires at least two options: [executable] [list of input files ...].");
-        return 255;
-      }
-      break;
     case CreateJobsIndex:
-      if (!vm.count("executable") && !vm.count("jobcommand")) {
-        ELOG(1, "'"+command+"' requires two options: [executable] [jobcommand].");
-        return 255;
-      }
       break;
     case CheckResultsIndex:
@@ -404 +452 @@
     case ReceiveMPQCIndex:
       if (!vm.count("fragment-path")) {
-        ELOG(1, "'"+command+"' require one option: [path to fragment files].");
+        ELOG(1, "'"+ControllerInfo.command+"' require one option: [path to fragment files].");
         return 255;
       }
@@ -414 +462 @@
     case UnknownCommandIndex:
     default:
-      ELOG(1, "Unrecognized command '"+toString(command)+"'.");
+      ELOG(1, "Unrecognized command '"+toString(ControllerInfo.command)+"'.");
       return 255;
       break;
@@ -429 +477 @@
     switch(commandIndex) {
       case AddJobsIndex:
-        controller.requestIds(server, serverport, vm["jobfiles"].as< std::vector<std::string> >().size());
+        controller.requestIds(ControllerInfo.server, ControllerInfo.serverport, vm["jobfiles"].as< std::vector<std::string> >().size());
         break;
       case CreateJobsIndex:
-        controller.requestIds(server, serverport, 1);
+        controller.requestIds(ControllerInfo.server, ControllerInfo.serverport, 1);
         break;
       case CheckResultsIndex:
@@ -446 +494 @@
       case UnknownCommandIndex:
       default:
-        ELOG(0, "Unrecognized command '"+toString(command)+"'.");
+        ELOG(0, "Unrecognized command '"+toString(ControllerInfo.command)+"'.");
         return 255;
         break;
@@ -474 +522 @@
         }
         controller.addJobs(jobs);
-        controller.sendJobs(server, serverport);
+        controller.sendJobs(ControllerInfo.server, ControllerInfo.serverport);
         break;
       }
@@ -481 +529 @@
         const JobId_t next_id = controller.getAvailableId();
         std::vector<FragmentJob::ptr> jobs;
-        const std::string executable = vm["executable"].as< std::string >();
-        const std::string jobcommand = vm["jobcommand"].as< std::string >();
-        createjobs(jobs, executable, jobcommand, next_id);
+        createjobs(jobs, ControllerInfo.executable, ControllerInfo.jobcommand, next_id);
         controller.addJobs(jobs);
-        controller.sendJobs(server, serverport);
+        controller.sendJobs(ControllerInfo.server, ControllerInfo.serverport);
         break;
       }
       case CheckResultsIndex:
-        controller.checkResults(server, serverport);
+        controller.checkResults(ControllerInfo.server, ControllerInfo.serverport);
         break;
       case ReceiveResultsIndex:
       case ReceiveMPQCIndex:
-        controller.receiveResults(server, serverport);
+        controller.receiveResults(ControllerInfo.server, ControllerInfo.serverport);
         break;
       case RemoveAllIndex:
-        controller.removeall(server, serverport);
+        controller.removeall(ControllerInfo.server, ControllerInfo.serverport);
         break;
       case ShutdownIndex:
-        controller.shutdown(server, serverport);
+        controller.shutdown(ControllerInfo.server, ControllerInfo.serverport);
         break;
       case UnknownCommandIndex:
       default:
-        ELOG(0, "Unrecognized command '"+toString(command)+"'.");
+        ELOG(0, "Unrecognized command '"+toString(ControllerInfo.command)+"'.");
         return 255;
         break;
@@ -549 +595 @@
       case UnknownCommandIndex:
       default:
-        ELOG(0, "Unrecognized command '"+toString(command)+"'.");
+        ELOG(0, "Unrecognized command '"+toString(ControllerInfo.command)+"'.");
         return 255;
         break;