Changeset 98ad30

Timestamp:

Dec 19, 2025, 11:29:38 PM (9 days ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.1, stable

Children:

44d5d9

Parents:

25aa214

git-author:

Frederik Heber <frederik.heber@…> (11/16/25 12:48:52)

git-committer:

Frederik Heber <frederik.heber@…> (12/19/25 23:29:38)

Message:

QtView: SingleShort timer fires every 10ms.

• moreover, we only fire it again if there are new changes before the last redraw (after 10ms) has started.

Location:

src/UIElements/Views/Qt4/Qt3D

Files:

• GLWorldView.cpp (modified) (15 diffs)
• GLWorldView.hpp (modified) (3 diffs)

src/UIElements/Views/Qt4/Qt3D/GLWorldView.cpp

@@ -94 +94 @@
   connect(worldscene, SIGNAL(hoverEnd()), this, SLOT(triggerUpdateGL()));
   connect(worldscene, SIGNAL(updated()), this, SLOT(triggerUpdateGL()));
-  connect(this, SIGNAL(updated()), this, SLOT(triggerUpdateGL()));
+  connect(this, SIGNAL(updated(const bool)), this, SLOT(triggerUpdateGL(const bool)));
   connect(worldscene, SIGNAL(sceneChanged()), this, SLOT(sceneChangeSignalled()));
   connect(this, SIGNAL(moleculesVisibilityChanged(ObservedValue_Index_t,bool)),
@@ -322 +322 @@
 void GLWorldView::update(Observable *publisher)
 {
-//  emit updated();
+//  emit updated(true);
 }
 
@@ -347 +347 @@
       observerLog().addMessage() << "++ Observer " << observerLog().getName(static_cast<Observer *>(this)) << " received notification that WorldTime's time has changed.";
 #endif
-        needsRedraw = false;
-        emit updated();
+        emit updated(false);
         emit TimeChanged();
         break;
@@ -389 +388 @@
   setdreiBeinStatus(!status);
   // realize
-  needsRedraw = true;
-  emit updated();
+  emit updated(true);
 }
 
@@ -407 +405 @@
   setDomainStatus(!status);
   // realize
-  needsRedraw = true;
-  emit updated();
+  emit updated(true);
 }
 
@@ -419 +416 @@
 }
 
-void GLWorldView::triggerUpdateGL()
-{
-  redrawTimer->singleShot(0, this, SLOT(updateGL()));
-  redrawTimer->start();
+void GLWorldView::triggerUpdateGL(const bool _needsRedraw)
+{
+  if ((!needsRedraw) && (_needsRedraw)) {
+    // accumulate updates over 10ms
+    needsRedraw = true;
+    redrawTimer->singleShot(10, this, SLOT(updateGL()));
+    redrawTimer->start();
+  }
+}
+
+void GLWorldView::updateGL()
+{
+  needsRedraw = false;
+  QGLView::updateGL();
 }
 
@@ -551 +558 @@
   setStereoType(QGLView::Hardware);
   camera()->setEyeSeparation(0.0);
-  emit updated();
+  emit updated(true);
 }
 
@@ -558 +565 @@
   setStereoType(QGLView::Hardware);
   camera()->setEyeSeparation(defaultEyeSeparation);
-  emit updated();
+  emit updated(true);
 }
 
@@ -565 +572 @@
   setStereoType(QGLView::LeftRight);
   camera()->setEyeSeparation(defaultEyeSeparation);
-  emit updated();
+  emit updated(true);
 }
 
@@ -572 +579 @@
   setStereoType(QGLView::RightLeft);
   camera()->setEyeSeparation(defaultEyeSeparation);
-  emit updated();
+  emit updated(true);
 }
 
@@ -579 +586 @@
   setStereoType(QGLView::TopBottom);
   camera()->setEyeSeparation(defaultEyeSeparation);
-  emit updated();
+  emit updated(true);
 }
 
@@ -586 +593 @@
   setStereoType(QGLView::BottomTop);
   camera()->setEyeSeparation(defaultEyeSeparation);
-  emit updated();
+  emit updated(true);
 }
 
@@ -593 +600 @@
   setStereoType(QGLView::RedCyanAnaglyph);
   camera()->setEyeSeparation(defaultEyeSeparation);
-  emit updated();
+  emit updated(true);
 }
 
@@ -726 +733 @@
 {
   emit hoverChanged(_id);
-  emit updated();
+  emit updated(true);
 }
 
@@ -732 +739 @@
 {
   emit hoverChanged(_id, _i);
-  emit updated();
-}
+  emit updated(true);
+}

src/UIElements/Views/Qt4/Qt3D/GLWorldView.hpp

@@ -60 +60 @@
 public slots:
   void sceneChangeSignalled();
-  void triggerUpdateGL();
+  void triggerUpdateGL(const bool _needsRedraw = true);
   void sceneHoverSignalled(const atomId_t _id);
   void sceneHoverSignalled(const moleculeId_t _id, int);
@@ -67 +67 @@
 
 signals:
-  void updated();
+  void updated(const bool _needsRedraw);
   void sceneUpdated();
   void TimeChanged();
@@ -83 +83 @@
   void drawDomainBox(QGLPainter *painter) const;
   void drawDreiBein(QGLPainter *painter);
+  void updateGL();
 
   // input functions