Changeset 77c4a0 for ThirdParty/CodePatterns

Timestamp:

Apr 23, 2021, 8:51:43 PM (5 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.0, stable

Children:

c18a79

Parents:

2b88eb

git-author:

Frederik Heber <frederik.heber@…> (11/25/20 00:09:13)

git-committer:

Frederik Heber <frederik.heber@…> (04/23/21 20:51:43)

Message:

Observable_protector requires noexcept(false).

• otherwise we cannot use the CircleDetection unit test anymore as C++11 default behavior is to terminate if an exception is thrown during a destructor (here, Observable_protector, i.e. OBSERVE; going out of scope). The unit test expects an AssertionFailure which we then no longer obtain but the whole test terminates. Therefore we set to noexcept(false) and allow exceptions to escape.

Location:

ThirdParty/CodePatterns/src

Files:

• CodePatterns/Observer/Observable.hpp (modified) (1 diff)
• Observer/Observable.cpp (modified) (1 diff)

ThirdParty/CodePatterns/src/CodePatterns/Observer/Observable.hpp

@@ -186 +186 @@
     _Observable_protector(Observable *);
     _Observable_protector(const _Observable_protector&);
-    ~_Observable_protector();
+    /*
+     * Since C++11 exceptions thrown during a destructor will always result
+     * in terminate. Here, however, we throw an AssertionFailure in case
+     * we detec a circle in the observation DAG. For the unit test to be
+     * useful, we need the exception to be handled normally (and not
+     * terminate). Hence, we set the behavior to allowing exceptions here.
+     */
+    ~_Observable_protector() noexcept(false);
   private:
     Observable *protege;

ThirdParty/CodePatterns/src/Observer/Observable.cpp

@@ -127 +127 @@
  * \param *protege Observable to be protected.
  */
-Observable::_Observable_protector::~_Observable_protector()
+Observable::_Observable_protector::~_Observable_protector() noexcept(false)
 {
   finish_observer_internal(protege);