Changeset 68c923 for src

Timestamp:

Dec 28, 2011, 3:24:24 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

b136f6

Parents:

de29ad6

git-author:

Frederik Heber <heber@…> (11/29/11 08:22:26)

git-committer:

Frederik Heber <heber@…> (12/28/11 15:24:24)

Message:

Lots of small compiler warning fixes.

Issues:

• non-virtual destructor despite virtual functions.
• unused variables.
• no break at end of switch case.
• no value returned.

Location:

src

Files:

• Actions/MoleculeAction/FillWithMoleculeAction.cpp (modified) (1 diff)
• Actions/WorldAction/CenterInBoxAction.cpp (modified) (1 diff)
• Box.cpp (modified) (1 diff)
• Graph/BondGraph.hpp (modified) (1 diff)
• IPointCloud.hpp (modified) (2 diffs)
• Parser/ChangeTracker.hpp (modified) (1 diff)
• Tesselation/BoundaryTriangleSet.cpp (modified) (1 diff)
• UIElements/Menu/TextMenu/ActionMenuItem.hpp (modified) (1 diff)
• UIElements/Menu/TextMenu/TextMenu.hpp (modified) (1 diff)

src/Actions/MoleculeAction/FillWithMoleculeAction.cpp

@@ -68 +68 @@
   molecule *filler = World::getInstance().getMolecule(MoleculeByOrder(-1)); // get last molecule
   filler->SetNameFromFilename(params.fillername.string().c_str());
-  molecule *Filling = NULL;
+//    molecule *Filling = NULL;
 //    atom *first = NULL, *second = NULL, *third = NULL;
 //    first = World::getInstance().createAtom();

src/Actions/WorldAction/CenterInBoxAction.cpp

@@ -53 +53 @@
   std::stringstream undostream;
   boost::archive::text_oarchive oa(undostream);
-  RealSpaceMatrix matrix(World::getInstance().getDomain().getM());
+  const RealSpaceMatrix &matrix = World::getInstance().getDomain().getM();
   oa << matrix;
   std::vector< boost::shared_ptr<Vector> > OldPositions;

src/Box.cpp

@@ -120 +120 @@
     default:
       ASSERT(0,"No default case for this");
+      break;
     }
 

src/Graph/BondGraph.hpp

@@ -199 +199 @@
     };
     // skip headers
-    unsigned int bondcount = 0;
     for (unsigned int i=0;i<skiplines;i++)
       input->getline(line,MAXSTRINGSIZE);

src/IPointCloud.hpp

@@ -14 +14 @@
 #endif
 
-
-#include <cstdio>
+#include <string>
 
 class TesselPoint;
@@ -22 +21 @@
 /** Encapsulates a set of TesselPoints with an internal iterator.
  */
-class IPointCloud {
+struct IPointCloud {
 public:
   virtual const std::string& GetName() const=0;

src/Parser/ChangeTracker.hpp

@@ -41 +41 @@
   // private constructor and destructor due to singleton
   ChangeTracker();
-  ~ChangeTracker();
+  virtual ~ChangeTracker();
 };
 

src/Tesselation/BoundaryTriangleSet.cpp

@@ -192 +192 @@
     return false;
   }
-}
-;
+  return true;
+}
+
 
 /** Finds the point on the triangle to the point \a *x.

src/UIElements/Menu/TextMenu/ActionMenuItem.hpp

@@ -30 +30 @@
 public:
   ActionMenuItem(char,const std::string &,TxMenu* const,const std::string &);
-  ~ActionMenuItem();
+  virtual ~ActionMenuItem();
 
   virtual void doTrigger();

src/UIElements/Menu/TextMenu/TextMenu.hpp

@@ -66 +66 @@
    *
    */
-  ~TextMenu()
+  virtual ~TextMenu()
   {
     ShortcutMap.clear();