Changeset 601ef8 for src/Actions

Timestamp:

Jan 12, 2015, 10:10:30 PM (10 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

2440ce

Parents:

33c97e

git-author:

Frederik Heber <heber@…> (12/14/14 19:10:19)

git-committer:

Frederik Heber <heber@…> (01/12/15 22:10:30)

Message:

FIX: ActionQueue is no longer cleared when Action fails.

• we only remove the present and all following Actions.
• also cleaned up threaded/non-threaded parts of ActionQueue: CurrentAction, tempQueue is solely used in threaded part.

Location:

src/Actions

Files:

• Action.cpp (modified) (1 diff)
• ActionQueue.cpp (modified) (12 diffs)
• ActionQueue.hpp (modified) (5 diffs)

src/Actions/Action.cpp

@@ -146 +146 @@
   endTimer();
 
-  if(shouldUndo() && state != failure){
-    if(canUndo()){
+  if (shouldUndo() && state != Action::failure) {
+    if (canUndo()) {
       ActionQueue::getInstance().addElement(this,state);
     }

src/Actions/ActionQueue.cpp

@@ -44 +44 @@
 #include <boost/date_time/posix_time/posix_time.hpp>
 #include <boost/version.hpp>
+#include <iterator>
 #include <string>
 #include <sstream>
@@ -61 +62 @@
     AR(new ActionRegistry()),
     history(new ActionHistory),
-    CurrentAction(0),
 #ifndef HAVE_ACTION_THREAD
     lastActionOk(true)
 #else
+    CurrentAction(0),
     lastActionOk(true),
     run_thread(boost::bind(&ActionQueue::run, this)),
@@ -82 +83 @@
 #ifdef HAVE_ACTION_THREAD
   stop();
+
+  clearTempQueue();
 #endif
 
@@ -111 +114 @@
     std::cerr << "Action " << *boost::get_error_info<ActionNameString>(e) << " has failed." << std::endl;
     World::getInstance().setExitFlag(5);
-//    clearQueue();
+    clearQueue(actionqueue.size()-1);
     lastActionOk = false;
-//    std::cerr << "ActionQueue cleared." << std::endl;
+    std::cerr << "Remaining Actions cleared from queue." << std::endl;
   } catch (std::exception &e) {
     pushStatus("FAIL: General exception caught, aborting.");
     World::getInstance().setExitFlag(134);
-    clearQueue();
+    clearQueue(actionqueue.size()-1);
     lastActionOk = false;
-    std::cerr << "ActionQueue cleared." << std::endl;
+    std::cerr << "Remaining Actions cleared from queue." << std::endl;
   }
   if (lastActionOk) {
@@ -127 +130 @@
   }
 #else
-  {
-    boost::lock_guard<boost::mutex> lock(mtx_idle);
-    run_thread_isIdle = (CurrentAction == actionqueue.size());
-  }
+  setRunThreadIdle(CurrentAction == actionqueue.size());
   mtx_queue.unlock();
 #endif
@@ -144 +144 @@
   mtx_queue.lock();
   tempqueue.push_back( newaction );
-  {
-    boost::lock_guard<boost::mutex> lock(mtx_idle);
-    run_thread_isIdle = !((CurrentAction != actionqueue.size()) || !tempqueue.empty());
-  }
+  setRunThreadIdle( !((CurrentAction != actionqueue.size()) || !tempqueue.empty()) );
   mtx_queue.unlock();
 #endif
@@ -184 +181 @@
         pushStatus("FAIL: Action "+*boost::get_error_info<ActionNameString>(e)+" has failed.");
         World::getInstance().setExitFlag(5);
-        clearQueue();
+        clearQueue(CurrentAction);
+        clearTempQueue();
         lastActionOk = false;
-        std::cerr << "ActionQueue cleared." << std::endl;
-        CurrentAction = (size_t)-1;
+        std::cerr << "Remaining Actions cleared from queue." << std::endl;
       } catch (std::exception &e) {
         pushStatus("FAIL: General exception caught, aborting.");
         World::getInstance().setExitFlag(134);
-        clearQueue();
-        std::cerr << "ActionQueue cleared." << std::endl;
-        CurrentAction = (size_t)-1;
+        clearQueue(CurrentAction);
+        clearTempQueue();
+        std::cerr << "Remaining Actions cleared from queue." << std::endl;
       }
       if (lastActionOk) {
@@ -199 +196 @@
         NOTIFY(ActionQueued);
         _lastchangedaction = actionqueue[CurrentAction];
+        mtx_queue.lock();
+        CurrentAction++;
+        mtx_queue.unlock();
       }
       // access actionqueue, hence using mutex
       mtx_queue.lock();
-      // step on to next action and check for end
-      CurrentAction++;
       // insert new actions (before [CurrentAction]) if they have been spawned
       // we must have an extra vector for this, as we cannot change actionqueue
@@ -211 +209 @@
       mtx_queue.unlock();
     }
-    {
-      boost::lock_guard<boost::mutex> lock(mtx_idle);
-      run_thread_isIdle = !((CurrentAction != actionqueue.size()) || !tempqueue.empty());
-    }
+    setRunThreadIdle( !((CurrentAction != actionqueue.size()) || !tempqueue.empty()) );
     cond_idle.notify_one();
 //    LOG(1, "DEBUG: End of ActionQueue's run() loop.");
   } while (!Interrupted);
 }
-#endif
 
 void ActionQueue::insertTempQueue()
@@ -231 +225 @@
 }
 
-#ifdef HAVE_ACTION_THREAD
 void ActionQueue::wait()
 {
@@ -316 +309 @@
 }
 
-void ActionQueue::clearQueue()
-{
-  // free all actions contained in actionqueue
-  for (ActionQueue_t::iterator iter = actionqueue.begin();
-      !actionqueue.empty(); iter = actionqueue.begin()) {
+void ActionQueue::clearQueue(const size_t _fromAction)
+{
+#ifdef HAVE_ACTION_THREAD
+  mtx_queue.lock();
+#endif
+  LOG(1, "Removing all Actions from position " << _fromAction << " onward.");
+  // free all actions still to be called contained in actionqueue
+  ActionQueue_t::iterator inititer = actionqueue.begin();
+  std::advance(inititer, _fromAction);
+  for (ActionQueue_t::iterator iter = inititer; iter != actionqueue.end(); ++iter)
     delete *iter;
-    actionqueue.erase(iter);
-  }
+  actionqueue.erase(inititer, actionqueue.end());
+  LOG(1, "There are " << actionqueue.size() << " remaining Actions.");
+#ifdef HAVE_ACTION_THREAD
+  CurrentAction = actionqueue.size();
+  mtx_queue.unlock();
+#endif
+}
+
+#ifdef HAVE_ACTION_THREAD
+void ActionQueue::clearTempQueue()
+{
   // free all actions contained in tempqueue
   for (ActionQueue_t::iterator iter = tempqueue.begin();
@@ -330 +337 @@
     tempqueue.erase(iter);
   }
-#ifdef HAVE_ACTION_THREAD
+}
+
+void ActionQueue::setRunThreadIdle(const bool _flag)
+{
   {
     boost::unique_lock<boost::mutex> lock(mtx_idle);
-    run_thread_isIdle = true;
-  }
-#endif
-}
+    run_thread_isIdle = _flag;
+  }
+}
+#endif
 
 const ActionQueue::ActionTokens_t ActionQueue::getListOfActions() const

src/Actions/ActionQueue.hpp

@@ -202 +202 @@
   void clear();
 
-  /** Clears all actions currently present in the actionqueues.
-   *
-   */
-  void clearQueue();
-
-#ifdef HAVE_ACTION_THREAD
+  /** Clears all actions present in the actionqueues from \a _fromAction.
+   *
+   * @param _fromAction 0 if all Actions to clear or else
+   */
+  void clearQueue(const size_t _fromAction = 0);
+
+#ifdef HAVE_ACTION_THREAD
+
+  /** Clears the temporary queue.
+   *
+   */
+  void clearTempQueue();
+
+  /** Sets the run_thread_isIdle flag.
+   *
+   * @param _flag state to set to
+   */
+  void setRunThreadIdle(const bool _flag);
+
   /** Runs the ActionQueue.
    *
@@ -226 +239 @@
    */
   void wait();
+
+  /** Moves all action from tempqueue into real queue.
+   *
+   */
+  void insertTempQueue();
+
 #endif
 
@@ -236 +255 @@
   void insertAction(Action *_action, enum Action::QueryOptions state);
 
-  /** Moves all action from tempqueue into real queue.
-   *
-   */
-  void insertTempQueue();
-
 private:
   /** Private cstor for ActionQueue.
@@ -267 +281 @@
   ActionQueue_t actionqueue;
 
+  //!> indicates that the last action has failed
+  bool lastActionOk;
+
+#ifdef HAVE_ACTION_THREAD
   //!> point to current action in actionqueue
   size_t CurrentAction;
@@ -273 +291 @@
   ActionQueue_t tempqueue;
 
-  //!> indicates that the last action has failed
-  bool lastActionOk;
-
-#ifdef HAVE_ACTION_THREAD
   //!> internal thread to call Actions
   boost::thread run_thread;