Changeset 45f5d6 for src/UIElements

Timestamp:

Jan 13, 2010, 10:22:29 AM (15 years ago)

Author:

Tillmann Crueger <crueger@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

7aa000

Parents:

aab2b1

Message:

Changed dialog structure to use objects for queries.

Location:

src/UIElements

Files:

• Dialog.cpp (modified) (1 diff)
• Dialog.hpp (modified) (2 diffs)
• TextDialog.cpp (modified) (1 diff)
• TextDialog.hpp (modified) (2 diffs)

src/UIElements/Dialog.cpp ¶

@@ -14 +14 @@
 Dialog::Dialog()
 {
-  // TODO Auto-generated constructor stub
-
 }
 
 Dialog::~Dialog()
 {
-  // TODO Auto-generated destructor stub
+  list<Query*>::iterator iter;
+  for(iter=queries.begin();iter!=queries.end();iter++){
+    delete (*iter);
+  }
 }
 
-void Dialog::queryInt(const char *_title, int *_target) {
-  Query q;
-  q.title = _title;
-  q.type = Int;
-  q.target = (void*) _target;
-
-  queries.push_back(q);
+void Dialog::registerQuery(Query *query){
+  queries.push_back(query);
 }
 
-void Dialog::queryString(const char *_title, string *_target) {
-    Query q;
-    q.title = _title;
-    q.type = String;
-    q.target = (void*) _target;
-
-    queries.push_back(q);
+bool Dialog::display(){
+  list<Query*>::iterator iter;
+  bool retval = true;
+  for(iter=queries.begin(); iter!=queries.end(); iter++){
+    retval &= (*iter)->handle();
+    // if any query fails (is canceled), we can end the handling process
+    if(!retval)
+      break;
+  }
+  if (retval){
+    // if all queries succeeded we can set the targets to appropriate values
+    for(iter=queries.begin(); iter!=queries.end(); iter++) {
+      (*iter)->setResult();
+    }
+  }
+  return retval;
 }
 
-void Dialog::display(){
-  list<Query>::iterator iter;
-  for(iter=queries.begin(); iter!=queries.end(); iter++){
-    switch((*iter).type) {
-      case Int:
-        handleInt((*iter).title,(int*)((*iter).target));
-        break;
-      case String:
-        handleString((*iter).title,(string*)((*iter).target));
-        break;
-      default:
-        assert(0 && "This type of query does not seem to exist... Something is seriously wrong");
-        break;
-    }
-  }
+Dialog::Query::Query(string _title) :
+    title(_title)
+{}
+
+Dialog::Query::~Query() {}
+
+const std::string Dialog::Query::getTitle() const{
+  return title;
 }
+
+Dialog::IntQuery::IntQuery(string title,int *_target) :
+    Query(title), target(_target)
+{}
+
+Dialog::IntQuery::~IntQuery() {}
+
+void Dialog::IntQuery::setResult() {
+  *target = tmp;
+}
+
+Dialog::StringQuery::StringQuery(string title,string *_target) :
+    Query(title), target(_target)
+{}
+
+Dialog::StringQuery::~StringQuery() {};
+
+void Dialog::StringQuery::setResult() {
+  *target = tmp;
+}
+

src/UIElements/Dialog.hpp ¶

@@ -12 +12 @@
 #include<list>
 
+class MoleculeListClass;
+class Molecule;
+
 class Dialog
 {
@@ -18 +21 @@
   virtual ~Dialog();
 
-  void queryInt(const char *, int *);
-  void queryString(const char*, std::string *);
+  virtual void queryInt(const char *, int *)=0;
+  virtual void queryString(const char*, std::string *)=0;
+ // virtual void queryMolecule(const char*,MoleculeListClass*,Molecule*)=0;
 
-  virtual void display();
+  virtual bool display();
 
 protected:
-  virtual void handleInt(std::string,int *)=0;
-  virtual void handleString(std::string,std::string *)=0;
-
-
-private:
   // methodology for handling queries
   // all queries are stored and then performed at appropriate times
 
   //these queries can be handled by this dialog
-  enum QueryType {Int,String};
-  struct Query {
+
+  //TODO: Find a way to reduce complexity...
+  //needs O(N*M) query classes, where N is the number of query types and M is the number of GUIs
+  //usual approach for reducing inheritance complexity (strategy pattern) does not work,
+  //due to lack of common code for query types as well as GUI-Types (all subtypes differ a lot)
+
+  //base class for all queries
+  class Query {
+  public:
+    Query(std::string _title);
+    ~Query();
+    virtual bool handle()=0;
+    virtual void setResult()=0;
+  protected:
+    const std::string getTitle() const;
+  private:
     std::string title;
-    QueryType type;
-    void *target;
   };
 
-  std::list<Query> queries;
+  //Specialized classes for certain types. GUI-Types are not specialized at this time
+  class IntQuery : public Query {
+  public:
+    IntQuery(std::string title,int *_target);
+    ~IntQuery();
+    virtual bool handle()=0;
+    virtual void setResult();
+  protected:
+    int tmp;
+  private:
+    int *target;
+  };
+
+  class StringQuery : public Query {
+  public:
+    StringQuery(std::string title,std::string *_target);
+    ~StringQuery();
+    virtual bool handle()=0;
+    virtual void setResult();
+  protected:
+    std::string tmp;
+  private:
+    std::string *target;
+  };
+
+void registerQuery(Query* query);
+
+private:
+  std::list<Query*> queries;
 
 };

src/UIElements/TextDialog.cpp ¶

@@ -17 +17 @@
 TextDialog::TextDialog()
 {
-  // TODO Auto-generated constructor stub
-
 }
 
 TextDialog::~TextDialog()
 {
-  // TODO Auto-generated destructor stub
 }
 
-void TextDialog::handleInt(std::string title, int *target) {
-  Log() << Verbose(0) << title;
-  cin >> (*target);
+void TextDialog::queryInt(const char* title, int* target){
+  registerQuery(new IntTextQuery(title,target));
 }
 
-void TextDialog::handleString(std::string title, string *target) {
-  string input;
-  Log() << Verbose(0) << title;
-  cin >> (*target);
+void TextDialog::queryString(const char* title, string* target){
+  registerQuery(new StringTextQuery(title,target));
 }
+
+TextDialog::IntTextQuery::IntTextQuery(string title,int *_target) :
+    Dialog::IntQuery(title,_target)
+{}
+
+TextDialog::IntTextQuery::~IntTextQuery() {}
+
+bool TextDialog::IntTextQuery::handle() {
+  Log() << Verbose(0) << IntQuery::getTitle();
+  cin >> tmp;
+  return true;
+}
+
+TextDialog::StringTextQuery::StringTextQuery(string title,string *_target) :
+    Dialog::StringQuery(title,_target)
+{}
+
+TextDialog::StringTextQuery::~StringTextQuery() {}
+
+bool TextDialog::StringTextQuery::handle() {
+  Log() << Verbose(0) << StringQuery::getTitle();
+  cin >> tmp;
+  return true;
+}

src/UIElements/TextDialog.hpp ¶

@@ -9 +9 @@
 #define TEXTDIALOG_HPP_
 
+#include <string>
+
 #include "UIElements/Dialog.hpp"
 
@@ -17 +19 @@
   virtual ~TextDialog();
 
-  virtual void handleInt(std::string,int *);
-  virtual void handleString(std::string,std::string *);
+  virtual void queryInt(const char *, int *);
+  virtual void queryString(const char*, std::string *);
+
+protected:
+  // specialized stuff for text queries
+  class IntTextQuery : public Dialog::IntQuery {
+  public:
+    IntTextQuery(std::string title, int *_target);
+    ~IntTextQuery();
+    virtual bool handle();
+  };
+
+  class StringTextQuery : public Dialog::StringQuery {
+  public:
+    StringTextQuery(std::string title, std::string *_target);
+    ~StringTextQuery();
+    virtual bool handle();
+  };
 };