Changeset 361805 for src

Timestamp:

Jun 13, 2012, 5:39:14 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

b2e31a

Parents:

23958d

git-author:

Michael Ankele <ankele@…> (05/10/12 15:06:04)

git-committer:

Frederik Heber <heber@…> (06/13/12 17:39:14)

Message:

BoxVectorValidator implemented

• TESTFIX: Created BoxVectorValidatorStub used in ActionRegistryUnitTest and ActionSequenceUnitTest.

Location:

src

Files:

• Actions/unittests/Makefile.am (modified) (2 diffs)
• Parameters/Makefile.am (modified) (1 diff)
• Parameters/Validators/Specific/BoxVectorValidator.cpp (added)
• Parameters/Validators/Specific/BoxVectorValidator.hpp (modified) (1 diff)
• Parameters/unittests/stubs/BoxVectorValidatorStub.cpp (added)

src/Actions/unittests/Makefile.am

@@ -32 +32 @@
         ../Actions/unittests/ActionRegistryUnitTest.cpp \
         ../Actions/unittests/ActionRegistryUnitTest.hpp \
-        ../Parameters/unittests/stubs/BoxLengthValidatorStub.cpp
+        ../Parameters/unittests/stubs/BoxLengthValidatorStub.cpp \
+        ../Parameters/unittests/stubs/BoxVectorValidatorStub.cpp
 ActionRegistryUnitTest_LDADD = ${ACTIONLIBS}
 
@@ -39 +40 @@
         ../Actions/unittests/ActionSequenceUnitTest.hpp \
         ../Actions/unittests/stubs/DummyUI.hpp \
-        ../Parameters/unittests/stubs/BoxLengthValidatorStub.cpp
+        ../Parameters/unittests/stubs/BoxLengthValidatorStub.cpp \
+        ../Parameters/unittests/stubs/BoxVectorValidatorStub.cpp
 ActionSequenceUnitTest_LDADD = \
         ${ACTIONLIBS} \

src/Parameters/Makefile.am

@@ -4 +4 @@
 
 PARAMETERSOURCE = \
-        Parameters/Validators/Specific/BoxLengthValidator.cpp
+        Parameters/Validators/Specific/BoxLengthValidator.cpp \
+        Parameters/Validators/Specific/BoxVectorValidator.cpp
 
 PARAMETERHEADER = \

src/Parameters/Validators/Specific/BoxVectorValidator.hpp

@@ -17 +17 @@
 #include "LinearAlgebra/Vector.hpp"
 
-#include "Parameters/Validators/DummyValidator.hpp"
+#include "Parameters/Validators/Validator.hpp"
 
 /** This validator checks whether the given Vector is within the current
  * simulation domain, i.e. the Box.
  */
-class BoxVectorValidator : public DummyValidator< Vector >
-{};
+class BoxVectorValidator : public Validator< Vector >
+{
+  bool isValid(const Vector & Vector) const;
+  bool operator==(const Validator<Vector> &_instance) const;
+  Validator< Vector >* clone() const;
+};