Changeset 13d5a9 for src

Timestamp:

Apr 26, 2010, 1:49:59 PM (15 years ago)

Author:

Tillmann Crueger <crueger@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

5f612ee

Parents:

8bb2fd

Message:

Added macros that allow type safe casting using the Assert mechanism

Location:

src

Files:

• Actions/small_actions.cpp (modified) (1 diff)
• Helpers/Assert.cpp (modified) (1 diff)
• Helpers/Assert.hpp (modified) (3 diffs)

src/Actions/small_actions.cpp

@@ -55 +55 @@
 
 Action::state_ptr ChangeMoleculeNameAction::performUndo(Action::state_ptr _state) {
-  ChangeMoleculeNameState *state = dynamic_cast<ChangeMoleculeNameState*>(_state.get());
-  ASSERT(state,"State passed to ChangeMoleculeNameAction::performUndo did not have correct type");
+  ChangeMoleculeNameState *state = assert_cast<ChangeMoleculeNameState*>(_state.get());
 
   string newName = state->mol->getName();

src/Helpers/Assert.cpp

@@ -48 +48 @@
 Action _my_assert::defaultAction = Ask;
 std::vector<Assert::hook_t> _my_assert::hooks;
+
+std::map<std::string,bool> _wrapper::ignores;
+const char* _wrapper::message_ptr = "source pointer did not point to object of desired type";
+const char* _wrapper::message_ref = "source reference did not contain object of desired type";
+
+
 
 bool _my_assert::check(const bool res,

src/Helpers/Assert.hpp

@@ -9 +9 @@
 #define ASSERT_HPP_
 
+#include<sstream>
 #include<string>
+#include<iostream>
 #include<vector>
+#include<map>
 
 /**
@@ -215 +218 @@
  */
 
+#ifndef NDEBUG
+  #ifndef STRINGIFY
+    #define STRINGIFY(x) #x
+  #endif
+
+  #ifdef __GNUC__
+    // on gcc we know how to exit to the Debugger
+    #define DEBUG_BREAK __builtin_trap()
+  #else
+    #define DEBUG_BREAK exit(1)
+  #endif
+
+  #define ASSERT(condition,message) \
+    do{\
+      static bool ignore = false;\
+      if(!ignore){\
+        if(Assert::_my_assert::check((condition),STRINGIFY(condition),(message),\
+                                     __FILE__,__LINE__,ignore)){\
+          Assert::_my_assert::doHooks();\
+          DEBUG_BREAK;\
+        }\
+      } \
+    }while(0)
+
+  #define ASSERT_NOCATCH(message) \
+                catch(Assert::AssertionFailure&){throw;}\
+                catch(...){\
+                  static bool ignore = false; \
+                  if(!ignore){\
+                          if(Assert::_my_assert::check(false,"Exception caught",(message),__FILE__,__LINE__,ignore)){\
+                            Assert::_my_assert::doHooks();\
+          DEBUG_BREAK;\
+                          }\
+                  }\
+                } do{(void)(0);}while(0)
+
+  #define assert_cast Assert::_wrapper(__LINE__,__FILE__)._convert
+
+  #define ASSERT_DO(action)    do{Assert::_my_assert::setDefault(action);}while(0)
+  #define ASSERT_HOOK(hook)    do{Assert::_my_assert::addHook(hook);}while(0)
+  #define ASSERT_UNHOOK(hook)  do{Assert::_my_assert::removeHook(hook);}while(0)
+  #define ASSERT_DEFAULT       (Assert::_myAssert::printDefault())
+#else
+  // we need to do something, so this is the usual solution (e.g. assert.h)
+  #define ASSERT(condition,message) (void)(0)
+  #define ASSERT_NOCATCH(message)   catch(...) {throw;} do{(void)(0);}while(0)
+  #define assert_cast static_cast
+  #define ASSERT_DO(action)         (void)(0)
+  #define ASSERT_HOOK(hook)         (void)(0)
+  #define ASSERT_UNHOOK(hook)       (void)(0)
+  #define ASSERT_DEFAULT            std::string("Deactivated")
+#endif
+
 namespace Assert{
 
@@ -238 +294 @@
     std::string message;
   };
+
+  //! @cond
+#ifndef NDEBUG
+    class _my_assert{
+    public:
+      static bool check(const bool res,
+                        const char* condition,
+                        const char* message,
+                        const char* filename,
+                        const int line,
+                        bool& ignore);
+      static void addHook(Assert::hook_t hook);
+      static void removeHook(Assert::hook_t hook);
+      static void doHooks();
+      static void setDefault(Assert::Action);
+      static Assert::Action getDefault();
+      static std::string printDefault();
+    private:
+      static Assert::Action defaultAction;
+      static std::vector<Assert::hook_t> hooks;
+    };
+
+
+  class _wrapper{
+  public:
+    _wrapper(int _line,const char* _file) :
+      line(_line),
+      file(_file)
+      {}
+
+    // Overloaded template for pointers
+    template<typename target,typename source>
+    target _convert(source *src){
+      std::stringstream sstr;
+      sstr << file << ":" << line;
+      bool &ignore = ignores[sstr.str()];
+
+      if(!ignore){
+        if(_my_assert::check(dynamic_cast<target>(src)==static_cast<target>(src),"type-safe typecast",
+                                       message_ptr,file,line,ignore)){
+          _my_assert::doHooks();
+          DEBUG_BREAK;
+        }
+      }
+      return static_cast<target>(src);
+    }
+
+    // Overloaded template for references
+    template<typename target, typename source>
+    target _convert(source &src){
+            std::stringstream sstr;
+      sstr << file << ":" << line;
+      bool &ignore = ignores[sstr.str()];
+
+      try{
+        target res =dynamic_cast<target>(src);
+        return res;
+      }
+      catch(...){
+        if(!ignore){
+          if(_my_assert::check(0,"type-safe typecast",message_ref,file,line,ignore)){
+            _my_assert::doHooks();
+            DEBUG_BREAK;
+          }
+        }
+      }
+      // The error was ignored. Just return whatever a static_cast would do
+      return static_cast<target>(src);
+    }
+  private:
+    int line;
+    const char *file;
+    static std::map<std::string,bool> ignores;
+    // this avoids duplication of the strings when templates are instantiated
+    static const char* message_ptr;
+    static const char* message_ref;
+  };
+#endif
+  //! @endcond
 }
 
-#ifndef NDEBUG
-  #ifndef STRINGIFY
-    #define STRINGIFY(x) #x
-  #endif
-
-  #ifdef __GNUC__
-    // on gcc we know how to exit to the Debugger
-    #define DEBUG_BREAK __builtin_trap()
-  #else
-    #define DEBUG_BREAK exit(1)
-  #endif
-
-  #define ASSERT(condition,message) \
-    do{\
-      static bool ignore = false;\
-      if(!ignore){\
-        if(_my_assert::check((condition),STRINGIFY(condition),(message),__FILE__,__LINE__,ignore)){\
-          _my_assert::doHooks();\
-          DEBUG_BREAK;\
-        }\
-      } \
-    }while(0)
-
-  #define ASSERT_NOCATCH(message) \
-                catch(Assert::AssertionFailure&){throw;}\
-                catch(...){\
-                  static bool ignore = false; \
-                  _my_assert::check(false,"Exception caught",(message),__FILE__,__LINE__,ignore);\
-                } do{(void)(0);}while(0)
-
-  #define ASSERT_DO(action)    do{_my_assert::setDefault(action);}while(0)
-  #define ASSERT_HOOK(hook)    do{_my_assert::addHook(hook);}while(0)
-  #define ASSERT_UNHOOK(hook)  do{_my_assert::removeHook(hook);}while(0)
-  #define ASSERT_DEFAULT       (_myAssert::printDefault())
-#else
-  // we need to do something, so this is the usual solution (e.g. assert.h)
-  #define ASSERT(condition,message) (void)(0)
-  #define ASSERT_NOCATCH(message)   catch(...) {throw;} do{(void)(0);}while(0)
-  #define ASSERT_DO(action)         (void)(0)
-  #define ASSERT_HOOK(hook)         (void)(0)
-  #define ASSERT_UNHOOK(hook)       (void)(0)
-  #define ASSERT_DEFAULT            std::string("Deactivated")
-#endif
-
-//! @cond
-class _my_assert{
-public:
-  static bool check(const bool res,
-                    const char* condition,
-                    const char* message,
-                    const char* filename,
-                    const int line,
-                    bool& ignore);
-  static void addHook(Assert::hook_t hook);
-  static void removeHook(Assert::hook_t hook);
-  static void doHooks();
-  static void setDefault(Assert::Action);
-  static Assert::Action getDefault();
-  static std::string printDefault();
-private:
-  static Assert::Action defaultAction;
-  static std::vector<Assert::hook_t> hooks;
-};
-//! @endcond
+