Action_Thermostats
        Add_AtomRandomPerturbation
        Add_FitFragmentPartialChargesAction
        Add_RotateAroundBondAction
        Add_SelectAtomByNameAction
        Added_ParseSaveFragmentResults
        AddingActions_SaveParseParticleParameters
        Adding_Graph_to_ChangeBondActions
        Adding_MD_integration_tests
        Adding_ParticleName_to_Atom
        Adding_StructOpt_integration_tests
        AtomFragments
        Automaking_mpqc_open
        AutomationFragmentation_failures
        Candidate_v1.5.4
        Candidate_v1.6.0
        Candidate_v1.6.1
        Candidate_v1.7.0
        ChangeBugEmailaddress
        ChangingTestPorts
        ChemicalSpaceEvaluator
        CombiningParticlePotentialParsing
        Combining_Subpackages
        Debian_Package_split
        Debian_package_split_molecuildergui_only
        Disabling_MemDebug
        Docu_Python_wait
        EmpiricalPotential_contain_HomologyGraph
        EmpiricalPotential_contain_HomologyGraph_documentation
        Enable_parallel_make_install
        Enhance_userguide
        Enhanced_StructuralOptimization
        Enhanced_StructuralOptimization_continued
        Example_ManyWaysToTranslateAtom
        Exclude_Hydrogens_annealWithBondGraph
        FitPartialCharges_GlobalError
        Fix_BoundInBox_CenterInBox_MoleculeActions
        Fix_ChargeSampling_PBC
        Fix_ChronosMutex
        Fix_FitPartialCharges
        Fix_FitPotential_needs_atomicnumbers
        Fix_ForceAnnealing
        Fix_IndependentFragmentGrids
        Fix_ParseParticles
        Fix_ParseParticles_split_forward_backward_Actions
        Fix_PopActions
        Fix_QtFragmentList_sorted_selection
        Fix_Restrictedkeyset_FragmentMolecule
        Fix_StatusMsg
        Fix_StepWorldTime_single_argument
        Fix_Verbose_Codepatterns
        Fix_fitting_potentials
        Fixes
        ForceAnnealing_goodresults
        ForceAnnealing_oldresults
        ForceAnnealing_tocheck
        ForceAnnealing_with_BondGraph
        ForceAnnealing_with_BondGraph_continued
        ForceAnnealing_with_BondGraph_continued_betteresults
        ForceAnnealing_with_BondGraph_contraction-expansion
        FragmentAction_writes_AtomFragments
        FragmentMolecule_checks_bonddegrees
        GeometryObjects
        Gui_Fixes
        Gui_displays_atomic_force_velocity
        ImplicitCharges
        IndependentFragmentGrids
        IndependentFragmentGrids_IndividualZeroInstances
        IndependentFragmentGrids_IntegrationTest
        IndependentFragmentGrids_Sole_NN_Calculation
        JobMarket_RobustOnKillsSegFaults
        JobMarket_StableWorkerPool
        JobMarket_unresolvable_hostname_fix
        MoreRobust_FragmentAutomation
        ODR_violation_mpqc_open
        PartialCharges_OrthogonalSummation
        PdbParser_setsAtomName
        PythonUI_with_named_parameters
        QtGui_reactivate_TimeChanged_changes
        Recreated_GuiChecks
        Rewrite_FitPartialCharges
        RotateToPrincipalAxisSystem_UndoRedo
        SaturateAtoms_findBestMatching
        SaturateAtoms_singleDegree
        StoppableMakroAction
        Subpackage_CodePatterns
        Subpackage_JobMarket
        Subpackage_LinearAlgebra
        Subpackage_levmar
        Subpackage_mpqc_open
        Subpackage_vmg
        Switchable_LogView
        ThirdParty_MPQC_rebuilt_buildsystem
        TrajectoryDependenant_MaxOrder
        TremoloParser_IncreasedPrecision
        TremoloParser_MultipleTimesteps
        TremoloParser_setsAtomName
        Ubuntu_1604_changes
        stable
      
      
        
          | Last change
 on this file since 0516fd was             87d6bd, checked in by Frederik Heber <heber@…>, 12 years ago | 
        
          | 
FIX: Fixing several clang errors such that we may safely use the compiler.
 
Changes:
 clang does not like execeptions as pure forward declarations.
clang does not like AtomTypes[MaxTypes] with MaxTypes being dynamic.
clang does not like cppunit to have no operator<<() for std::sets (it though
finds the ones for std::vector?), it cannot use one from toString.hpp as it
is declared afterwards (although before instantiation site).
clang does not tolerate inheriting from a protected member class TQuery.
clang does not tolerate shadowing of a variable inside a for-loop (i.e.
declaring variable in loop body with same name as e.g. loop variable).
 clang compilation ran through after these changes without a single failing
test.
 | 
        
          | 
              
Property                 mode
 set to                 100644 | 
        
          | File size:
            1.8 KB | 
      
      
| Line |  | 
|---|
| 1 | /* | 
|---|
| 2 | * RangeValidator_impl.hpp | 
|---|
| 3 | * | 
|---|
| 4 | *  Created on: Apr 16, 2012 | 
|---|
| 5 | *      Author: ankele | 
|---|
| 6 | */ | 
|---|
| 7 |  | 
|---|
| 8 | #ifndef RANGEVALIDATOR_IMPL_HPP_ | 
|---|
| 9 | #define RANGEVALIDATOR_IMPL_HPP_ | 
|---|
| 10 |  | 
|---|
| 11 |  | 
|---|
| 12 | // include config.h | 
|---|
| 13 | #ifdef HAVE_CONFIG_H | 
|---|
| 14 | #include <config.h> | 
|---|
| 15 | #endif | 
|---|
| 16 |  | 
|---|
| 17 | template <class T> | 
|---|
| 18 | bool RangeValidator<T>::isValid(const T & _value) const | 
|---|
| 19 | { | 
|---|
| 20 | bool isBefore = true; | 
|---|
| 21 | bool isBeyond = true; | 
|---|
| 22 | // check left boundary | 
|---|
| 23 | isBefore = ValidRange.isBefore(_value); | 
|---|
| 24 | //  if (isBefore) | 
|---|
| 25 | //    LOG(0, "INFO: " << _value << " is before " << ValidRange.first << "."); | 
|---|
| 26 | // check right boundary | 
|---|
| 27 | isBeyond = ValidRange.isBeyond(_value) && (_value != ValidRange.last); | 
|---|
| 28 | //  if (isBeyond) | 
|---|
| 29 | //    LOG(0, "INFO: " << _value << " is beyond " << ValidRange.last << "."); | 
|---|
| 30 | return (!isBefore) && (!isBeyond); | 
|---|
| 31 | } | 
|---|
| 32 |  | 
|---|
| 33 | template <class T> | 
|---|
| 34 | Validator<T>* RangeValidator<T>::clone() const | 
|---|
| 35 | { | 
|---|
| 36 | return new RangeValidator<T>(ValidRange); | 
|---|
| 37 | }; | 
|---|
| 38 |  | 
|---|
| 39 | // comparator | 
|---|
| 40 | template <class T> | 
|---|
| 41 | bool RangeValidator<T>::operator==(const Validator<T> &_instance) const | 
|---|
| 42 | { | 
|---|
| 43 | const RangeValidator<T> *inst = dynamic_cast<const RangeValidator<T> *>(&_instance); | 
|---|
| 44 | if (inst) | 
|---|
| 45 | return ValidRange == inst->ValidRange; | 
|---|
| 46 | return false; | 
|---|
| 47 | }; | 
|---|
| 48 |  | 
|---|
| 49 |  | 
|---|
| 50 | /** Setter for the valid range. | 
|---|
| 51 | * | 
|---|
| 52 | * \note Check whether range invalidates values is done in Value<T>. | 
|---|
| 53 | * | 
|---|
| 54 | * @param _range range (pair of values) | 
|---|
| 55 | */ | 
|---|
| 56 | template <class T> | 
|---|
| 57 | void RangeValidator<T>::setValidRange(const range<T> &_range) throw(ParameterValueException) | 
|---|
| 58 | { | 
|---|
| 59 | ValidRange = _range; | 
|---|
| 60 | } | 
|---|
| 61 |  | 
|---|
| 62 | // specialization for Vector | 
|---|
| 63 | #include "LinearAlgebra/Vector.hpp" | 
|---|
| 64 |  | 
|---|
| 65 | class Vector; | 
|---|
| 66 |  | 
|---|
| 67 | template <> | 
|---|
| 68 | inline bool RangeValidator<Vector>::isValid(const Vector & _value) const | 
|---|
| 69 | { | 
|---|
| 70 | return ValidRange.first[0] <= _value[0] && _value[0] < ValidRange.last[0] && | 
|---|
| 71 | ValidRange.first[1] <= _value[1] && _value[1] < ValidRange.last[1] && | 
|---|
| 72 | ValidRange.first[2] <= _value[2] && _value[2] < ValidRange.last[2]; | 
|---|
| 73 | } | 
|---|
| 74 |  | 
|---|
| 75 |  | 
|---|
| 76 | #endif /* RANGEVALIDATOR_IMPL_HPP_ */ | 
|---|
       
      
  Note:
 See   
TracBrowser
 for help on using the repository browser.