source: src/Filling/Filler.cpp@ b3d687

Action_Thermostats Add_AtomRandomPerturbation Add_FitFragmentPartialChargesAction Add_RotateAroundBondAction Add_SelectAtomByNameAction Added_ParseSaveFragmentResults AddingActions_SaveParseParticleParameters Adding_Graph_to_ChangeBondActions Adding_MD_integration_tests Adding_ParticleName_to_Atom Adding_StructOpt_integration_tests AtomFragments Automaking_mpqc_open AutomationFragmentation_failures Candidate_v1.5.4 Candidate_v1.6.0 Candidate_v1.6.1 ChangeBugEmailaddress ChangingTestPorts ChemicalSpaceEvaluator CombiningParticlePotentialParsing Combining_Subpackages Debian_Package_split Debian_package_split_molecuildergui_only Disabling_MemDebug Docu_Python_wait EmpiricalPotential_contain_HomologyGraph EmpiricalPotential_contain_HomologyGraph_documentation Enable_parallel_make_install Enhance_userguide Enhanced_StructuralOptimization Enhanced_StructuralOptimization_continued Example_ManyWaysToTranslateAtom Exclude_Hydrogens_annealWithBondGraph FitPartialCharges_GlobalError Fix_BoundInBox_CenterInBox_MoleculeActions Fix_ChargeSampling_PBC Fix_ChronosMutex Fix_FitPartialCharges Fix_FitPotential_needs_atomicnumbers Fix_ForceAnnealing Fix_IndependentFragmentGrids Fix_ParseParticles Fix_ParseParticles_split_forward_backward_Actions Fix_PopActions Fix_QtFragmentList_sorted_selection Fix_Restrictedkeyset_FragmentMolecule Fix_StatusMsg Fix_StepWorldTime_single_argument Fix_Verbose_Codepatterns Fix_fitting_potentials Fixes ForceAnnealing_goodresults ForceAnnealing_oldresults ForceAnnealing_tocheck ForceAnnealing_with_BondGraph ForceAnnealing_with_BondGraph_continued ForceAnnealing_with_BondGraph_continued_betteresults ForceAnnealing_with_BondGraph_contraction-expansion FragmentAction_writes_AtomFragments FragmentMolecule_checks_bonddegrees GeometryObjects Gui_Fixes Gui_displays_atomic_force_velocity ImplicitCharges IndependentFragmentGrids IndependentFragmentGrids_IndividualZeroInstances IndependentFragmentGrids_IntegrationTest IndependentFragmentGrids_Sole_NN_Calculation JobMarket_RobustOnKillsSegFaults JobMarket_StableWorkerPool JobMarket_unresolvable_hostname_fix MoreRobust_FragmentAutomation ODR_violation_mpqc_open PartialCharges_OrthogonalSummation PdbParser_setsAtomName PythonUI_with_named_parameters QtGui_reactivate_TimeChanged_changes Recreated_GuiChecks Rewrite_FitPartialCharges RotateToPrincipalAxisSystem_UndoRedo SaturateAtoms_findBestMatching SaturateAtoms_singleDegree StoppableMakroAction Subpackage_CodePatterns Subpackage_JobMarket Subpackage_LinearAlgebra Subpackage_levmar Subpackage_mpqc_open Subpackage_vmg Switchable_LogView ThirdParty_MPQC_rebuilt_buildsystem TrajectoryDependenant_MaxOrder TremoloParser_IncreasedPrecision TremoloParser_MultipleTimesteps TremoloParser_setsAtomName Ubuntu_1604_changes stable
Last change on this file since b3d687 was b3d687, checked in by Frederik Heber <heber@…>, 13 years ago

FIX: Filler::operator() did not create a molecule for each cloned cluster.

  • so far we assume (in AtomicInfo) that each atoms always belongs to a molecule. However, the CopyAtomsInterface copies without creating new molecules or associating copied ones with the old molecules.
  • AtomicInfo asserts that atom is associated to a molecule.
  • CopyAtoms_withBonds now associates cloned atoms with molecule of original atom.
  • Filler::operator() creates a molecule for each cloned cluster and associates all atoms in the cluster with it.
  • This [closes #180].
  • Property mode set to 100644
File size: 5.8 KB
Line 
1/*
2 * Project: MoleCuilder
3 * Description: creates and alters molecular systems
4 * Copyright (C) 2012 University of Bonn. All rights reserved.
5 * Please see the LICENSE file or "Copyright notice" in builder.cpp for details.
6 */
7
8/*
9 * Filler.cpp
10 *
11 * Created on: Jan 16, 2012
12 * Author: heber
13 */
14
15
16// include config.h
17#ifdef HAVE_CONFIG_H
18#include <config.h>
19#endif
20
21#include "CodePatterns/MemDebug.hpp"
22
23#include <algorithm>
24#include <boost/bind.hpp>
25#include <boost/lambda/lambda.hpp>
26#include <sstream>
27#include <vector>
28
29#include "Filler.hpp"
30
31#include "CodePatterns/Assert.hpp"
32#include "CodePatterns/Log.hpp"
33
34#include "Atom/atom.hpp"
35#include "Box.hpp"
36#include "ClusterInterface.hpp"
37#include "Descriptors/AtomIdDescriptor.hpp"
38#include "Inserter/Inserter.hpp"
39#include "LinearAlgebra/RealSpaceMatrix.hpp"
40#include "LinearAlgebra/Vector.hpp"
41#include "molecule.hpp"
42#include "NodeTypes.hpp"
43#include "Predicates/FillPredicate.hpp"
44#include "Predicates/Ops_FillPredicate.hpp"
45#include "World.hpp"
46
47
48/** Constructor for class Filler.
49 *
50 * \note We store inverted \a _predicate because we need it only for
51 * remove_copy_if which works in this inverted way as desired.
52 *
53 * @param _mesh Mesh with a NodeSet that fills its Shape
54 * @param _predicate predicate construct to check at each Node
55 * @param _inserter inserter which places the cloned cluster
56 */
57Filler::Filler(const Mesh &_mesh, const FillPredicate &_predicate, const Inserter &_inserter) :
58 mesh(_mesh),
59 predicate(!_predicate),
60 inserter(_inserter)
61{}
62
63/** Destructor for class Filler.
64 *
65 */
66Filler::~Filler()
67{}
68
69/** Fill in the desired Cluster at each remaining node.
70 *
71 * \note The cluster is non-const because it is moved to the first vacant node.
72 *
73 * @param copyMethod functor that knows how to copy atoms.
74 * @param cluster set of atomic ids contained in a specific Shape to fill each Node with
75 * @return true - at least one node has been filled, false - no node filled
76 */
77bool Filler::operator()(
78 CopyAtomsInterface &copyMethod,
79 ClusterInterface::Cluster_impl cluster) const
80{
81 const NodeSet &nodes = mesh.getNodes();
82 std::stringstream output;
83 std::for_each( nodes.begin(), nodes.end(), output << boost::lambda::_1 << " ");
84 LOG(3, "DEBUG: Listing nodes to check: " << output.str());
85 if (nodes.size() == 0)
86 return false;
87 NodeSet FillNodes(nodes.size(), zeroVec);
88
89 // evaluate predicates at each FillNode
90 {
91 // move filler cluster's atoms out of domain such that it does not disturb the predicate.
92 // we only move the atoms as otherwise two translate ShapeOps will be on top of the Shape
93 // which is subsequently copied to all other cloned Clusters ...
94 Vector BoxDiagonal;
95 {
96 const RealSpaceMatrix &M = World::getInstance().getDomain().getM();
97 BoxDiagonal = (M * Vector(1.,1.,1.));
98 BoxDiagonal -= cluster->getShape().getCenter();
99 BoxDiagonal *= 1. + 2.*cluster->getShape().getRadius()/BoxDiagonal.Norm(); // extend it a little further
100 AtomIdSet atoms = cluster->getAtoms();
101 for (AtomIdSet::iterator iter = atoms.begin(); iter != atoms.end(); ++iter)
102 (*iter)->setPosition( (*iter)->getPosition() + BoxDiagonal );
103 LOG(1, "INFO: Translating original cluster's atoms by " << BoxDiagonal << ".");
104 }
105
106 // evaluate predicate and gather into new set
107 NodeSet::iterator transform_end =
108 std::remove_copy_if(nodes.begin(), nodes.end(), FillNodes.begin(), predicate );
109 FillNodes.erase(transform_end, FillNodes.end());
110
111 // shift cluster back to original place
112 {
113 AtomIdSet atoms = cluster->getAtoms();
114 for (AtomIdSet::iterator iter = atoms.begin(); iter != atoms.end(); ++iter)
115 (*iter)->setPosition( (*iter)->getPosition() - BoxDiagonal );
116 LOG(1, "INFO: Translating original cluster's atoms back.");
117 }
118 }
119
120 if (FillNodes.size() == 0) {
121 ELOG(2, "For none of the nodes did the predicate return true.");
122 return false;
123 } else {
124 LOG(1, "INFO: " << FillNodes.size() << " out of " << nodes.size() << " returned true from predicate.");
125 }
126
127 // clone clusters
128 std::vector<ClusterInterface::Cluster_impl> clusters(FillNodes.size());
129 {
130 std::vector<ClusterInterface::Cluster_impl>::iterator clusteriter = clusters.begin();
131 *clusteriter = cluster;
132 clusteriter++;
133 std::generate_n(clusteriter, FillNodes.size()-1,
134 boost::bind(&ClusterInterface::clone, boost::cref(cluster), boost::ref(copyMethod), zeroVec) );
135 }
136
137 // insert each cluster by abusing std::search a bit:
138 {
139 // we look for the subsequence of FillNodes inside clusters. If Inserter always
140 // returns true, we'll have the iterator pointing at first cluster
141 std::vector<ClusterInterface::Cluster_impl>::const_iterator inserteriter =
142 std::search(clusters.begin(), clusters.end(), FillNodes.begin(), FillNodes.end(),
143 boost::bind(&Inserter::operator(), boost::cref(inserter), _1, _2));
144 if( inserteriter != clusters.begin()) {
145 ELOG(1, "Not all cloned clusters could be successfully inserted.");
146 return false;
147 }
148 }
149
150 // create molecules for each cluster and fill in atoms
151 {
152 std::vector<molecule *> molecules(clusters.size()-1, NULL);
153 std::generate_n(molecules.begin(), FillNodes.size()-1,
154 boost::bind(&World::createMolecule, World::getPointer()) );
155 std::vector<ClusterInterface::Cluster_impl>::const_iterator clusteriter = clusters.begin();
156 ++clusteriter;
157 std::vector<molecule *>::iterator moliter = molecules.begin();
158 for (;moliter != molecules.end(); ++clusteriter, ++moliter) {
159 AtomIdSet atoms = (*clusteriter)->getAtoms();
160 for (AtomIdSet::iterator iter = atoms.begin(); iter != atoms.end(); ++iter)
161 (*moliter)->AddAtom(*iter);
162 }
163 }
164
165 // give final statment on whether at least \a single cluster has been placed
166 if ( FillNodes.size() != 0)
167 return true;
168 else
169 return false;
170}
171
Note: See TracBrowser for help on using the repository browser.